Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links ui on landscape iOS #647

Closed
wants to merge 3 commits into from
Closed

Conversation

etoledom
Copy link
Contributor

Description

This PR updates the Gutenberg ref to test WordPress/gutenberg#14047.

It fixes an issue on KeyboardAvoidingView, that was adding extra bottom padding on specific circumstances:

  • iOS.
  • Landscape.
  • Keyboard already present.
  • BottomSheet presenting with a TextInput on Autofocus.
  • It also had issues without Autofocus.

With some debugging I noticed a problem on the way the extra padding is calculated, so I made a simplified version of the component that will work well on the BottomSheet.

links-ui-landscape

Note: The BottomSheet is not scrollable (yet).

To test:

  • Check that the Links UI presents properly on Landscape mode.
  • If possible, test WPiOS and Android.
  • Android should work exactly as before.

@etoledom etoledom added this to the Beta milestone Feb 22, 2019
@etoledom etoledom self-assigned this Feb 22, 2019
@etoledom etoledom changed the title Update gutenberg ref Fix links ui on landscape iOS Feb 22, 2019
@etoledom etoledom modified the milestones: Beta, v1.0 Feb 22, 2019
@pinarol pinarol self-requested a review February 22, 2019 12:07
@etoledom etoledom modified the milestones: v1.0, Future Feb 22, 2019
@etoledom
Copy link
Contributor Author

This issue doesn't happen on the WP apps, it seems to just affect the example apps, so I'm moving the Milestone to check it out again later.

Thank you @pinarol !

@pinarol
Copy link
Contributor

pinarol commented Mar 5, 2019

so the extra padding issue is still not reproducible on my side even on example app. but there's another issue I could repro and this PR seems to fix that:

Before this PR the bottom sheet sometimes don't show itself in portrait mode:
before-fix-bottom-sheet

So this looks fixed now.

There are other 2 small issues reproducible after the fix though:

  1. The keyboard hide button stops working after the bottom sheet is closed until I manually go and tap to text in the block again.

  2. Don't know if this is a bug but when I tap to an outside area just after opening the BottomSheet and with no changes made(because I just want to close the BottomSheet) we add the link anyway using an empty url. I think if the user hadn't entered a url text this means we shouldn't add a link and just close the bottom sheet. wdyt?

bottom-sheet-keyboard-close

@etoledom
Copy link
Contributor Author

etoledom commented Mar 5, 2019

Closing in favor of #701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants