Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link added from empty link string. #703

Closed
etoledom opened this issue Mar 5, 2019 · 1 comment
Closed

Link added from empty link string. #703

etoledom opened this issue Mar 5, 2019 · 1 comment
Assignees
Labels
[Type] Bug Something isn't working

Comments

@etoledom
Copy link
Contributor

etoledom commented Mar 5, 2019

When you select some text on the paragraph block and press the Links button to add a link, the Links UI appears. If you dismiss it without adding any text to the URL filed, it will create a link with the url: http:\\

As a proposal: We shouldn't create a link if the url text is empty, but it should cancel the add-link action.

And (from @iamthomasbishop) we should consider a couple things:

  • Tapping return should probably dismiss the sheet altogether. Right now, it just hides the keyboard. If we do this, we should probably rename this ^^ button to done.

  • We should make sure the text input for URL use the URL input type/keyboard.

  • (Maybe for another ticket): We are automatically adding http:// to URLs when the user types a straight URL. If I type wordpress.org, I would expect it to stay as wordpress.org.

Reference:
#701 (comment)
#647 (comment)

bottom-sheet-keyboard-close

@etoledom
Copy link
Contributor Author

etoledom commented Mar 7, 2019

Fixed via WordPress/gutenberg#14270 and #701

@etoledom etoledom closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant