Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Image Size when url for slug doesn't exist #1611

Merged
merged 4 commits into from
Nov 28, 2019
Merged

Fix Image Size when url for slug doesn't exist #1611

merged 4 commits into from
Nov 28, 2019

Conversation

etoledom
Copy link
Contributor

Fixes n7 from #1593

More info in gutenberg side PR: WordPress/gutenberg#18698

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@etoledom etoledom added this to the 1.18 milestone Nov 22, 2019
@etoledom etoledom self-assigned this Nov 22, 2019
This was referenced Nov 22, 2019
Merged
Closed
SergioEstevao
SergioEstevao approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! :shipit:

mchowning
mchowning approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! 🙇‍♂️

@etoledom etoledom merged commit 0ba8d55 into develop Nov 28, 2019
@etoledom etoledom deleted the issue/image-size-improvements-mark-ii branch November 28, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@mchowning mchowning mchowning approved these changes

Assignees

@etoledom etoledom

Labels
bugfix
Projects
None yet
Milestone
1.18
Development

Successfully merging this pull request may close these issues.
3 participants
@etoledom @SergioEstevao @mchowning