Image Sizes behavioral issues

[etoledom]

This ticket tracks all the known issues on Image Size feature to be fixed before releasing it.

• 1. [WPiOS]: When selecting different a different image size, the image's size doesn't change visually. This is due to the Image.getSize call fails to return the correct size on urls with the form ...?w=100 (from what I tested), returning the full size all the time. Then this value is sent to the native side which uses Photon API to get the image with the given size.

  • PR: [Gutenberg] Image size improvements WordPress-iOS#12983

• 2. [WPiOS (Probably Android too)] When the image size request fails, Gutenberg won't ever request it again for the same image (on the same session). This might be a problem for users with bad connectivity.

• 3. Given that the previous problem occurs for any reason (like no internet connection or a self-hosted endpoint failing), setting the image size will fail. I believe we could not show the Image Size picker option if we don't have the Images size information requested.

  • PR: Image block: Hide Size options when Image object is undefined #1669

• 4. The default Image Size slug is Large, but the actual image URL is the full size one. On web, a new added image has set the proper Large image URL.

  • PR: Image Size improvements Mark I #1598

• 5. When an image has a slug set (let's say Thumb) and we change the image for a new one, the ImageSlug is not updated to the default one (it will remain as Thumb on this example).

  • PR: Image Size improvements Mark I #1598

• 6. Networking: API calls return unexpected errors in certain scenarios: Implement React Native bridge method for making api requests WordPress-Android#10779 (comment)

• 7. Non-standard size slugs: it seems that some images can have non-standard size slugs (i.e., no "large" size), which our code does not currently expect or handle. [RNMobile] Image Size improvements mark I WordPress/gutenberg#18627 (comment)

  • PR: Fix Image Size when url for slug doesn't exist #1611

• 8. Update Size picker UI.

  • PR: [RNMobile] Update image size UI control WordPress/gutenberg#19232

[etoledom]

With #1904 merged, we can close this ticket 🎉