Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep/110: modernize developer experience #166

Merged
merged 13 commits into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
module.exports = {
extends: ['plugin:@woocommerce/eslint-plugin/recommended'],
extends: [ 'plugin:@woocommerce/eslint-plugin/recommended' ],
globals: {
_: false,
Backbone: false,
jQuery: false,
wp: false,
wc: false,
wcSquareSettings: false,
},
settings: {
Expand All @@ -20,7 +21,7 @@ module.exports = {
],
'import/resolver': {
node: {
extensions: ['.js', '.jsx', '.ts', '.tsx'],
extensions: [ '.js', '.jsx', '.ts', '.tsx' ],
},
},
},
Expand All @@ -31,10 +32,16 @@ module.exports = {
'react-hooks/rules-of-hooks': 'off',
'@woocommerce/dependency-group': 'off',
camelcase: 'off',
'@wordpress/i18n-text-domain': [
'error',
{
allowedTextDomain: 'woocommerce-square',
},
],
},
overrides: [
{
files: ['**/assets/blocks/**/**.js'],
files: [ '**/assets/blocks/**/**.js' ],
globals: {
jQuery: true,
browser: true,
Expand Down
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ docs export-ignore
mode_modules export-ignore
wordpress-org-assets export-ignore
tests export-ignore
src export-ignore
test-plugins export-ignore

# Files
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ jobs:
run: ./tests/bin/set-core-version.js WordPress/WordPress#master

- name: Setup E2E environment
run: npm run test:env:start
run: npm run env:start

- name: Run E2E tests
id: square_e2e_tests
if: ${{ github.event_name == 'pull_request' }}
run: npm run test:e2e-run
run: npm run test:e2e

- name: Remove existing labels
uses: actions/github-script@v6
Expand Down Expand Up @@ -112,7 +112,7 @@ jobs:

- name: Run E2E Smoke Test
if: ${{ github.event_name == 'push' }}
run: npm run test:e2e-run
run: npm run test:e2e

- uses: actions/upload-artifact@v3
if: always()
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16
v20
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

## Getting Started

1. Make sure you have `git`, `node`, `npm` installed. We use the node LTS version on our servers, so we recommended
using that for development as well -- currently this is version `12.18.2`.
1. Make sure you have `git`, `node`, `npm` installed..
1. Clone this repository locally within the plugins directory of WordPress.
1. Run `nvm use` from the root directory of the repository to install the correct version of Node JS.
1. Run `npm install` from the root directory of the repository to install dependencies.
1. Execute `npm run build:dev` from the root directory of the repository.
1. Execute `npm run build` from the root directory of the repository.
1. Now go to the local installation, and activate this plugin.
1. [Signup for a Square sandbox account and input your App ID and Access Token](https://docs.woocommerce.com/document/woocommerce-square/#section-6)
1. From the dropdown box for location, choose a location(The default value is Default Test Account).
Expand Down
3 changes: 0 additions & 3 deletions assets/new-user-experience/components/section/index.js

This file was deleted.

This file was deleted.

46 changes: 0 additions & 46 deletions assets/new-user-experience/onboarding/data/selectors.js

This file was deleted.

Loading
Loading