-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upkeep/110: modernize developer experience #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a handful of comments but in testing, things seemed to work great. I see we're changing the textdomain in lots of JS files from woocommerce-square
to just woocommerce
. I left a handful of comments on this but then decided to quit flagging it. If this isn't intentional, we should change those back. If there is a reason why, would be curious to know.
Also, E2E tests are failing on this PR. Not sure it's related but would be great to get those fixed up so we can be confident these updates aren't causing problems.
src/new-user-experience/components/payment-gateway-settings-save-button/index.js
Outdated
Show resolved
Hide resolved
src/new-user-experience/components/square-settings-save-button/index.js
Outdated
Show resolved
Hide resolved
src/new-user-experience/components/square-settings-save-button/index.js
Outdated
Show resolved
Hide resolved
@dkotter the tests are passing locally in the first pass: ![]() I'll investigate why it is failing in pipeline. |
Regression / Smoke Test Report ✅Tested with Archive File created via "php woorelease.phar build repo_URL" (Composer version 2.5.5, npm version 8.19.4, node version 16.20.0) Status- Working expected with Plugin Archive/Zip file same as fix specific branch. Next Step- Ready to Merge 🚀 |
All Submissions:
Changes proposed in this Pull Request:
src/
Closes #110
Steps to test the changes in this Pull Request:
nvm use
ornvm install
depending on the situation.node -v && npm -v
.rm -rf node_modules/
.npm ci && npm run build
.Changelog entry