Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbox: Remove woo plugin check for eligibility checker #13325

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jul 15, 2024

Closes: #13322

Description

Previously in the eligibility checker for Inbox, we were checking version for the Woo plugin assuming there would be a change to filter inbox.

In #13214 we enabled the Inbox feature flag but didn't remove the Woo plugin check. This check is now redundant, so this PR removes it so that the eligibility check can be synchronous.

Also, I added a small improvement to support authenticating the admin page for self-hosted sites authenticated without WPCom.

Testing steps

  • Confirm that the entry points to Inbox on both the dashboard and hub menu still work as before.
  • Log out and log in again to a self-hosted store using application password.
  • Enable the inbox card on the dashboard screen or navigate to the inbox list from the hub menu.
  • Tap on any CTA that opens the admin page. Confirm that the page is authenticated automatically.

Screenshots

Hub menu Dashboard

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: technical debt Represents or solves tech debt of the project. category: inbox Related to the Inbox menu labels Jul 15, 2024
@itsmeichigo itsmeichigo added this to the 19.6 milestone Jul 15, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 15, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr13325-a8b3076
Version19.5
Bundle IDcom.automattic.alpha.woocommerce
Commita8b3076
App Center BuildWooCommerce - Prototype Builds #9997
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Base automatically changed from task/13181-remove-blaze-remote-feature-flag to trunk July 15, 2024 11:07
@selanthiraiyan selanthiraiyan self-assigned this Jul 16, 2024
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. This works as described and code LGTM. 🚀

I think the PR description should be updated to close #13322 instead of #13181.

@itsmeichigo itsmeichigo merged commit 13c483b into trunk Jul 16, 2024
22 checks passed
@itsmeichigo itsmeichigo deleted the task/13322-inbox-remove-plugin-check branch July 16, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: inbox Related to the Inbox menu type: technical debt Represents or solves tech debt of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inbox: Remove plugin check for eligibility checker
3 participants