Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbox: Remove plugin check for eligibility checker #13322

Closed
itsmeichigo opened this issue Jul 15, 2024 · 1 comment · Fixed by #13325
Closed

Inbox: Remove plugin check for eligibility checker #13322

itsmeichigo opened this issue Jul 15, 2024 · 1 comment · Fixed by #13325
Labels
type: enhancement A request for an enhancement.

Comments

@itsmeichigo
Copy link
Contributor

Previously in the eligibility checker for Inbox, we were checking version for the Woo plugin assuming there would be a change to filter inbox.

In #13214 we enable the Inbox feature flag but didn't remove the Woo plugin check. This check is now redundant and should be removed so that the eligibility check can be synchronous.

@itsmeichigo itsmeichigo added the type: enhancement A request for an enhancement. label Jul 15, 2024
@dangermattic
Copy link
Collaborator

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants