Fix default modalPresentationStyle on iOS 13 #5709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve-navigation into fixModalPresentationStyle
guyca
approved these changes
Dec 2, 2019
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
* Set as default modalPresentationStyle * Sets the system default modalPresentationStyle * Fix tests * Fix unit tests * Fix unit tests * Add modal.swipeToDismiss option
danilobuerger
added a commit
to danilobuerger/react-native-navigation
that referenced
this pull request
Aug 21, 2020
Changes the default from overFullScreen to fullScreen on iOS 12 and below. According to wix#5709 > Below iOS 13, the default presentation style is always fullScreen presentation style. Also looking at the blame it was indeed "fullScreen" not "overFullScreen" This is also inline with the docs https://wix.github.io/react-native-navigation/api/options-root#modalpresentationstyle > The default presentation style is different on each platform. > iOS 12 and below - fullScreen > iOS 13 and above - pageSheet
yogevbd
added a commit
that referenced
this pull request
Aug 31, 2020
Changes the default from overFullScreen to fullScreen on iOS 12 and below. According to #5709 > Below iOS 13, the default presentation style is always fullScreen presentation style. Also looking at the blame it was indeed "fullScreen" not "overFullScreen" This is also inline with the docs https://wix.github.io/react-native-navigation/api/options-root#modalpresentationstyle > The default presentation style is different on each platform. > iOS 12 and below - fullScreen > iOS 13 and above - pageSheet Co-authored-by: Yogev Ben David <yogev132@gmail.com> Co-authored-by: Guy Carmeli <guyca@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Resolve the default
modalPresentationStyleaccording to iOS version.In iOS 13 and above, the default presentation style for each view controller is resolved by the system.
Below iOS 13, the default presentation style is always
fullScreenpresentation style.• Add the ability to control swipe modal to dismiss when the presentation style sets to
pageSheetusingoptions.modal.swipeToDismiss