Skip to content

Commit

Permalink
Fix default modalPresentationStyle on < iOS 13 (#6494)
Browse files Browse the repository at this point in the history
Changes the default from overFullScreen to fullScreen on iOS 12 and below.

According to #5709
> Below iOS 13, the default presentation style is always fullScreen presentation style.

Also looking at the blame it was indeed "fullScreen" not "overFullScreen"

This is also inline with the docs https://wix.github.io/react-native-navigation/api/options-root#modalpresentationstyle

> The default presentation style is different on each platform.
> iOS 12 and below - fullScreen
> iOS 13 and above - pageSheet

Co-authored-by: Yogev Ben David <yogev132@gmail.com>
Co-authored-by: Guy Carmeli <guyca@users.noreply.github.com>
  • Loading branch information
3 people authored Aug 31, 2020
1 parent a80a0c7 commit 0869fd0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/ios/RNNConvert.m
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ + (UIModalPresentationStyle)defaultModalPresentationStyle {
if (@available(iOS 13.0, *)) {
return UIModalPresentationAutomatic;
} else {
return UIModalPresentationOverFullScreen;
return UIModalPresentationFullScreen;
}
}

Expand Down

0 comments on commit 0869fd0

Please sign in to comment.