-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easier rebuild of native modules #643
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c910cbc
New rebuild, implement wire_target_arch
ffflorian de5ac3f
Merge branch 'master' into rebuild
ffflorian a899895
Rebuild neon after installation
ffflorian 40e589b
Linting, add header
ffflorian 0fff9f1
Code review
ffflorian b7b6822
Remove space
ffflorian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
#!/usr/bin/env node | ||
/* | ||
* Wire | ||
* Copyright (C) 2017 Wire Swiss GmbH | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see http://www.gnu.org/licenses/. | ||
* | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const spawn = require('cross-spawn'); | ||
const exec = require('child_process').exec; | ||
const arch = process.env.wire_target_arch ? process.env.wire_target_arch : process.arch; | ||
|
||
const normalize = (args) => { | ||
return args.map((arg) => { | ||
Object.keys(process.env).forEach((key) => { | ||
const variableRegex = new RegExp(`\\$${key}|%${key}%`, 'i'); | ||
arg = arg.replace(variableRegex, process.env[key]); | ||
}); | ||
return arg; | ||
}); | ||
}; | ||
|
||
let args = process.argv.slice(2); | ||
if (args.length === 1) { | ||
const [command] = normalize(args); | ||
const proc = exec(command, (error, stdout, stderr) => { | ||
if (error) { | ||
console.error('Execution error: ', error); | ||
return; | ||
} | ||
process.stdout.write(stdout); | ||
process.stderr.write(stderr); | ||
process.exit(proc.code); | ||
}); | ||
} else { | ||
args = normalize(args); | ||
const command = args.shift(); | ||
args.unshift('--arch', arch, '--'); | ||
const proc = spawn.sync(command, args, {stdio: 'inherit'}); | ||
process.exit(proc.status); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for colon space (
:
) when using multi argumentsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, no need for the space - but the colon makes the error message more readable.