Easier rebuild of native modules #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennycode
suggested changes
May 16, 2017
electron/rebuild-native-modules.js
Outdated
| const normalize = (args) => { | ||
| return args.map((arg) => { | ||
| Object.keys(process.env).forEach((key) => { | ||
| const regex = new RegExp(`\\$${key}|%${key}%`, 'i'); |
There was a problem hiding this comment.
More descriptive name for regex. What does it match?
electron/rebuild-native-modules.js
Outdated
| const [command] = normalize(args); | ||
| const proc = exec(command, (error, stdout, stderr) => { | ||
| if (error) { | ||
| console.error(`exec error: ${error}`); |
There was a problem hiding this comment.
It's always good to mention the original error object, like:
console.error(`exec error: ${error}`, error);
lipis
reviewed
May 16, 2017
electron/rebuild-native-modules.js
Outdated
| const [command] = normalize(args); | ||
| const proc = exec(command, (error, stdout, stderr) => { | ||
| if (error) { | ||
| console.error('Execution error: ', error); |
There was a problem hiding this comment.
no need for colon space (: ) when using multi arguments
console.error('Execution error', error);
There was a problem hiding this comment.
True, no need for the space - but the colon makes the error message more readable.
bennycode
approved these changes
May 16, 2017
sidneys
added a commit
to sidneys/wire-desktop
that referenced
this pull request
May 18, 2017
* master: New native module rebuilding (wireapp#643) Publish amplify events when joining calls (wireapp#629) Use new V8 inspector (wireapp#641) electron 1.6.9 (wireapp#637) Release 2.14.2743 Add template for github issues Update libsodium-neon to 2.1.0 (wireapp#634) Update electron-build-env to 0.2.0 (wireapp#633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wire_target_arch.electron-rebuild.