Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize the Filter widget even when no scopes are initially defined #1206

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Sep 15, 2024

This makes it possible to dynamically extend filter scopes even if no scopes exist.

@mjauvin mjauvin changed the title Always setup the filter widget Setup the filter widget if no scpopes exist Sep 15, 2024
@mjauvin
Copy link
Member Author

mjauvin commented Sep 15, 2024

This is related to our issue:
ref. twigphp/Twig#4090

I was hoping I'd see a reference to a PR that fixed this BC break in the issue, no such luck...

@mjauvin
Copy link
Member Author

mjauvin commented Sep 15, 2024

Also related:
ref. twigphp/Twig#4090

@mjauvin
Copy link
Member Author

mjauvin commented Sep 15, 2024

I think this is the one that restored the previous behavior:
ref. twigphp/Twig#4216

@mjauvin mjauvin modified the milestones: 1.2.7, 1.2.8 Sep 22, 2024
@mjauvin mjauvin changed the title Setup the filter widget if no scpopes exist Setup the filter widget if no scopes exist Sep 24, 2024
@LukeTowers LukeTowers modified the milestones: 1.2.8, 1.2.7 Sep 26, 2024
@LukeTowers LukeTowers changed the title Setup the filter widget if no scopes exist Initialize the Filter widget even when no scopes are initially defined Sep 26, 2024
@LukeTowers LukeTowers merged commit fb325f5 into develop Sep 26, 2024
11 checks passed
@LukeTowers LukeTowers deleted the list-filter branch September 26, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants