Initialize the Filter widget even when no scopes are initially defined (

#1206)
wintercms · Sep 26, 2024 · fb325f5 · fb325f5
1 parent 58cab73
commit fb325f5
Showing 1 changed file with 27 additions and 29 deletions.
diff --git a/modules/backend/behaviors/ListController.php b/modules/backend/behaviors/ListController.php
@@ -235,39 +235,37 @@ public function makeList($definition = null)
         if (isset($listConfig->filter)) {
             $filterConfig = $this->makeConfig($listConfig->filter);
 
-            if (!empty($filterConfig->scopes)) {
-                $widget->cssClasses[] = 'list-flush';
-
-                $filterConfig->alias = $widget->alias . 'Filter';
-                $filterWidget = $this->makeWidget(\Backend\Widgets\Filter::class, $filterConfig);
-                $filterWidget->bindToController();
-
-                /*
-                * Filter the list when the scopes are changed
-                */
-                $filterWidget->bindEvent('filter.update', function () use ($widget, $filterWidget) {
-                    return $widget->onFilter();
-                });
+            $widget->cssClasses[] = 'list-flush';
 
-                /*
-                * Filter Widget with extensibility
-                */
-                $filterWidget->bindEvent('filter.extendScopes', function () use ($filterWidget) {
-                    $this->controller->listFilterExtendScopes($filterWidget);
-                });
+            $filterConfig->alias = $widget->alias . 'Filter';
+            $filterWidget = $this->makeWidget(\Backend\Widgets\Filter::class, $filterConfig);
+            $filterWidget->bindToController();
 
-                /*
-                * Extend the query of the list of options
-                */
-                $filterWidget->bindEvent('filter.extendQuery', function ($query, $scope) {
-                    $this->controller->listFilterExtendQuery($query, $scope);
-                });
+            /*
+            * Filter the list when the scopes are changed
+            */
+            $filterWidget->bindEvent('filter.update', function () use ($widget, $filterWidget) {
+                return $widget->onFilter();
+            });
 
-                // Apply predefined filter values
-                $widget->addFilter([$filterWidget, 'applyAllScopesToQuery']);
+            /*
+            * Filter Widget with extensibility
+            */
+            $filterWidget->bindEvent('filter.extendScopes', function () use ($filterWidget) {
+                $this->controller->listFilterExtendScopes($filterWidget);
+            });
 
-                $this->filterWidgets[$definition] = $filterWidget;
-            }
+            /*
+            * Extend the query of the list of options
+            */
+            $filterWidget->bindEvent('filter.extendQuery', function ($query, $scope) {
+                $this->controller->listFilterExtendQuery($query, $scope);
+            });
+
+            // Apply predefined filter values
+            $widget->addFilter([$filterWidget, 'applyAllScopesToQuery']);
+
+            $this->filterWidgets[$definition] = $filterWidget;
         }
 
         return $widget;