-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacer #1158 and Second Typo #1645 #1652
Conversation
Fixes winder#1645 Menu Multiply XY by 10 issue
Replacer without %macros%
Edge case debugged, no %macro% as yet until backend instance can be obtained (to get to the current Macros() definitions)
Sorted %macro% blockage using SettingsFactory vs Settings
Fixed typo in multiplyABCStepSize(), was using getStepSizeZ() and should have been getStepSizeABC(). Now fixed. Replacer functionality with %macro% expansion via sed syntax extensively tested and working as intended
Not sure what, if anything, I am supposed to do with the CodeBeat response. Nothing wrong with the code aside from style and brevity as-per it's assessment??? |
More_Typos in JogService.java, fixing divideABCStepSize()
Code Style Tweaks, adding "" to surround log entries to make more legible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tidied some comments to improve code style
Code simplified
As CodeBeat didn't like my coding style, I re-wrote the main PatternRemover loop to be more elegant - it is more legible and has fewer nesting levels. I also tested the Macro expansion against macros named '1' or 'Macro #1' as these could both exist, and it successfully identifies and expands either form. |
Replacer #1158 (PatternRemover enhancement) and Second Typo #1645 (ABC Step Multiply)
PatternRemover has been enhanced to support 'replace with' and %macro% expansion by introducing 'sed' syntax to the preferences/UGS/Contoller Options. 'sed' syntax is "s/regex to match/replacement text" so the following now all work;
Confirmed working (Apple and RPi).
Found a typo in jog service.java where getStepSizeZ() was errantly against multiplyABCStepSize(), should have been getStepSizeABC(), which is corrected.
Confirmed working (Apple and RPi).