Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Multiply XY Step Size by 10 not working #1645

Closed
AndyCXL opened this issue Jul 26, 2021 · 14 comments · Fixed by #1651
Closed

Menu Multiply XY Step Size by 10 not working #1645

AndyCXL opened this issue Jul 26, 2021 · 14 comments · Fixed by #1651

Comments

@AndyCXL
Copy link
Contributor

AndyCXL commented Jul 26, 2021

Describe the bug
Select Menu Multiply XY Step Size by 10, performs no action.
Not noticed any other such menu function omissions.

Expected behaviour
Expecting XY Step Size to x10. Divide by does work.

Version
UGS Platform 2.0.8-SNAPSHOT of 26-Jul-2021, 16:00 GMT+1

Hardware
GRBL 1.1t Mega 5X

Operating system (please complete the following information):
MacOSX

Additional context
Add any other context about the problem here.

@testanley3
Copy link

This bug also present in Windows 10 edition of the same version. Glad it's not just my imagination.

@AndyCXL
Copy link
Contributor Author

AndyCXL commented Aug 4, 2021

I have found the typo in the source that is causing this, and shortly will submit a pull request with the very simple fix.

AndyCXL added a commit to AndyCXL/Universal-G-Code-Sender that referenced this issue Aug 4, 2021
Fixes winder#1645 Menu Multiply XY by 10 issue
@testanley3
Copy link

Thank you for this fix. Forgive my ignorance, but how do I update my copy of the program to implement this change?

@AndyCXL
Copy link
Contributor Author

AndyCXL commented Aug 5, 2021

Several ways;

  1. Best is that my Pull Request is merged and this becomes part of the nightly builds
  2. You fork my copy (Menu_Multiply from GitHub AndyCXL) compile and use that until 1. happens

@AndyCXL
Copy link
Contributor Author

AndyCXL commented Aug 6, 2021

@testanley3 if you can PM me, I can send the ZIP file I have compiled of either Menu_Multiply or Replacer branches. It's not ideal as you are then wholly dependent on me, but if you can't compile from my repository it may a practical 'fix'.

breiler pushed a commit that referenced this issue Aug 7, 2021
Fixes #1645 Menu Multiply XY by 10 issue
@AndyCXL
Copy link
Contributor Author

AndyCXL commented Aug 9, 2021

@testanley3 Note that this proposed fix (Menu Multiply XY Step Size by 10) has been accepted and merged into the nightly builds, so you can download a 'fixed' version of UGS

@testanley3
Copy link

testanley3 commented Aug 9, 2021 via email

@testanley3
Copy link

testanley3 commented Aug 15, 2021 via email

@testanley3
Copy link

Sorry to be a nuisance, but I must not know how to download nightly builds. I am navigating to https://ugs.jfrog.io/ui/native/UGS/nightly and other than a .zip file for a Raspberry Pi version dated 08/02/21, the latest that I see for other platforms are dated 07/24/21. These do not seem to include the patch for the above discussed error of XY Jog Size Multiply. Where can I find a more recent nightly build for the Windows OS? Is it possible that July 24 WAS the last nightly build for this version? Please help. Thank you!

@AndyCXL
Copy link
Contributor Author

AndyCXL commented Aug 23, 2021

@testanley3 you are right, the nightly builds haven’t run since. Are you able to build the source yourself into the executable? That’s what I do. If not, it is down to the owners/administrators to run a nightly build so you can access it

@testanley3
Copy link

testanley3 commented Aug 23, 2021 via email

@AndyCXL
Copy link
Contributor Author

AndyCXL commented Aug 23, 2021

If you are able to PM me, I could send you a ZIP of the compiled files. It is circa 150MB all-in, so we'll have to find a way to transfer it (OneDrive or something)

@testanley3
Copy link

testanley3 commented Aug 23, 2021 via email

@AndyCXL
Copy link
Contributor Author

AndyCXL commented Aug 24, 2021

@testanley3 PM me at AndyCXL@corteen.org and we can set something up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants