Don't unblock rendering for implicitly render-blocking elements on `blocking` attribute changes #7857

xiaochengh · 2022-04-26T02:00:34Z

Fixes #7856. Also a minor fixup to #7474.

At least two implementers are interested (and none opposed):
- See Add the render-blocking mechanism and blocking=render attribute #7474
Tests are written and can be reviewed and commented upon at:
- https://chromium-review.googlesource.com/c/chromium/src/+/3608747
Implementation bugs are filed:
- See Add the render-blocking mechanism and blocking=render attribute #7474

(See WHATWG Working Mode: Changes for more details.)

/links.html ( diff )
/scripting.html ( diff )
/semantics.html ( diff )
/urls-and-fetching.html ( diff )

source

xiaochengh

Thanks for reviewing! PR updated.

source

xiaochengh · 2022-04-27T18:09:17Z

Friendly ping :)

…attribute is removed 1. This patch adds tests for whatwg/html#7857. When `blocking=render` is removed, if the element is implicitly render-blocking, we shouldn't unblock rendering for it. 2. This patch fixes how <link> element respond to `blocking` attribute changes. Previously, the element simply reprocesses (cancel and then restart) on every `blocking` attribute change, causing unnecessary work and also some bugs on stylesheets. This patch changes that into unblock rendering if needed to match the spec. Bug: 1271296 Change-Id: I54a2f33dc1ed9971eaeceeb677a165d598d5d4d1

…attribute is removed 1. This patch adds tests for whatwg/html#7857. When `blocking=render` is removed, if the element is implicitly render-blocking, we shouldn't unblock rendering for it. 2. This patch fixes how <link> element respond to `blocking` attribute changes. Previously, the element simply reprocesses (cancel and then restart) on every `blocking` attribute change, causing unnecessary work and also some bugs on stylesheets. This patch changes that into unblock rendering if needed to match the spec. Bug: 1271296 Change-Id: I54a2f33dc1ed9971eaeceeb677a165d598d5d4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3608747 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#998568}

…ender-blocking when blocking attribute is removed, a=testonly Automatic update from web-platform-tests [renderblocking] Don't cancel implicit render-blocking when blocking attribute is removed 1. This patch adds tests for whatwg/html#7857. When `blocking=render` is removed, if the element is implicitly render-blocking, we shouldn't unblock rendering for it. 2. This patch fixes how <link> element respond to `blocking` attribute changes. Previously, the element simply reprocesses (cancel and then restart) on every `blocking` attribute change, causing unnecessary work and also some bugs on stylesheets. This patch changes that into unblock rendering if needed to match the spec. Bug: 1271296 Change-Id: I54a2f33dc1ed9971eaeceeb677a165d598d5d4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3608747 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#998568} -- wpt-commits: 4de4be2a2204e4349b36dce25a9d648aba4fbf11 wpt-pr: 33798

Fixes #7893, which is a bug introduced by #7857.

…ender-blocking when blocking attribute is removed, a=testonly Automatic update from web-platform-tests [renderblocking] Don't cancel implicit render-blocking when blocking attribute is removed 1. This patch adds tests for whatwg/html#7857. When `blocking=render` is removed, if the element is implicitly render-blocking, we shouldn't unblock rendering for it. 2. This patch fixes how <link> element respond to `blocking` attribute changes. Previously, the element simply reprocesses (cancel and then restart) on every `blocking` attribute change, causing unnecessary work and also some bugs on stylesheets. This patch changes that into unblock rendering if needed to match the spec. Bug: 1271296 Change-Id: I54a2f33dc1ed9971eaeceeb677a165d598d5d4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3608747 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#998568} -- wpt-commits: 4de4be2a2204e4349b36dce25a9d648aba4fbf11 wpt-pr: 33798

Fixes whatwg#7893, which is a bug introduced by whatwg#7857.

This change reflects the renaming of "render-blocking" to "explicitly render-blocking" in whatwg/html#7857 It's also a preparation for implementing logic related to "implicitly render-blocking" in crrev.com/c/3608747 Bug: 1271296 Change-Id: I6724e7e4858e2b2c92398b8ff68c984f793a4753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3607827 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#997335} NOKEYCHECK=True GitOrigin-RevId: c1bcf0dcb6b206e42c82c515d89466133bddc045

…attribute is removed 1. This patch adds tests for whatwg/html#7857. When `blocking=render` is removed, if the element is implicitly render-blocking, we shouldn't unblock rendering for it. 2. This patch fixes how <link> element respond to `blocking` attribute changes. Previously, the element simply reprocesses (cancel and then restart) on every `blocking` attribute change, causing unnecessary work and also some bugs on stylesheets. This patch changes that into unblock rendering if needed to match the spec. Bug: 1271296 Change-Id: I54a2f33dc1ed9971eaeceeb677a165d598d5d4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3608747 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#998568} NOKEYCHECK=True GitOrigin-RevId: 831456d6a2d55d251875cdf15de4066e66d817e9

These tests were added in the follow PRs: web-platform-tests#32553 web-platform-tests#32669 web-platform-tests#32703 web-platform-tests#32809 web-platform-tests#33291 web-platform-tests#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857

These tests were added in these PRs: web-platform-tests#32553 web-platform-tests#32669 web-platform-tests#32703 web-platform-tests#32809 web-platform-tests#33291 web-platform-tests#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857

These tests were added in these PRs: #32553 #32669 #32703 #32809 #33291 #33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857

…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113

…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113 UltraBlame original commit: 58cb91eda01d9227e0e02791aa6562da04967a42

Mon Apr 25 04:56:57 PM PDT 2022

4dda6a8

xiaochengh commented Apr 26, 2022

View reviewed changes

source Show resolved Hide resolved

domenic reviewed Apr 26, 2022

View reviewed changes

source Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

Tue Apr 26 12:41:53 PM PDT 2022

1ae29f2

xiaochengh commented Apr 26, 2022

View reviewed changes

source Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

xiaochengh marked this pull request as ready for review April 26, 2022 19:42

domenic added normative change topic: rendering labels Apr 27, 2022

domenic approved these changes Apr 27, 2022

View reviewed changes

domenic merged commit a2a74be into whatwg:main Apr 27, 2022

chromium-wpt-export-bot mentioned this pull request Apr 27, 2022

[renderblocking] Don't cancel implicit render-blocking when blocking attribute is removed web-platform-tests/wpt#33798

Merged

xiaochengh deleted the issue7856 branch May 3, 2022 18:02

This was referenced May 6, 2022

The conditions when a script element is implicitly potentially render-blocking are wrong #7893

Closed

Fix when a script element is implicitly potentially render-blocking #7894

Merged

zcorpan pushed a commit that referenced this pull request May 16, 2022

Fix when a script element is implicitly potentially render-blocking

76f47d3

Fixes #7893, which is a bug introduced by #7857.

mfreed7 pushed a commit to mfreed7/html that referenced this pull request Jun 3, 2022

Fix when a script element is implicitly potentially render-blocking

185208a

Fixes whatwg#7893, which is a bug introduced by whatwg#7857.

foolip mentioned this pull request Nov 13, 2023

Mark most render-blocking tests no longer tentative web-platform-tests/wpt#43113

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't unblock rendering for implicitly render-blocking elements on `blocking` attribute changes #7857

Don't unblock rendering for implicitly render-blocking elements on `blocking` attribute changes #7857

xiaochengh commented Apr 26, 2022 •

edited by pr-preview bot

Loading

xiaochengh left a comment

xiaochengh commented Apr 27, 2022

Don't unblock rendering for implicitly render-blocking elements on blocking attribute changes #7857

Don't unblock rendering for implicitly render-blocking elements on blocking attribute changes #7857

Conversation

xiaochengh commented Apr 26, 2022 • edited by pr-preview bot Loading

xiaochengh left a comment

Choose a reason for hiding this comment

xiaochengh commented Apr 27, 2022

Don't unblock rendering for implicitly render-blocking elements on `blocking` attribute changes #7857

Don't unblock rendering for implicitly render-blocking elements on `blocking` attribute changes #7857

xiaochengh commented Apr 26, 2022 •

edited by pr-preview bot

Loading