-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tentative WPT tests for render-blocking elements #32669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
c3e0ee7
to
a3c7f8e
Compare
This patch adds more WPT tests for: - Parser-inserted preload links - Script-inserted stylesheet and preload links - Script-inserted style elements Bug: 1271296 Change-Id: I8f6ffc6a191370410da56b64d7ff8dba852e2732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435366 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#967088}
a3c7f8e
to
ae20f41
Compare
WPT Command: Some affected tests had inconsistent (flaky) results: Unstable results
These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag |
crbug/1294304 created. @past, can you force-merge this PR? |
Hmm, this is a newly proposed feature, and I'm not expecting Firefox to pass it. I'll look into it. |
Merged, thanks! |
…rm-tests#32669) This patch adds more WPT tests for: - Parser-inserted preload links - Script-inserted stylesheet and preload links - Script-inserted style elements Bug: 1271296 Change-Id: I8f6ffc6a191370410da56b64d7ff8dba852e2732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435366 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#967088} Co-authored-by: Xiaocheng Hu <xiaochengh@chromium.org>
…rm-tests#32669) This patch adds more WPT tests for: - Parser-inserted preload links - Script-inserted stylesheet and preload links - Script-inserted style elements Bug: 1271296 Change-Id: I8f6ffc6a191370410da56b64d7ff8dba852e2732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435366 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#967088} Co-authored-by: Xiaocheng Hu <xiaochengh@chromium.org>
These tests were added in the follow PRs: web-platform-tests#32553 web-platform-tests#32669 web-platform-tests#32703 web-platform-tests#32809 web-platform-tests#33291 web-platform-tests#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857
These tests were added in these PRs: web-platform-tests#32553 web-platform-tests#32669 web-platform-tests#32703 web-platform-tests#32809 web-platform-tests#33291 web-platform-tests#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857
These tests were added in these PRs: #32553 #32669 #32703 #32809 #33291 #33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113 UltraBlame original commit: 58cb91eda01d9227e0e02791aa6562da04967a42
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113 UltraBlame original commit: 58cb91eda01d9227e0e02791aa6562da04967a42
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113 UltraBlame original commit: 58cb91eda01d9227e0e02791aa6562da04967a42
This patch adds more WPT tests for:
Bug: 1271296
Change-Id: I8f6ffc6a191370410da56b64d7ff8dba852e2732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435366
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#967088}