Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when a script element is implicitly potentially render-blocking #7894

Merged
merged 1 commit into from
May 16, 2022

Conversation

xiaochengh
Copy link
Contributor

@xiaochengh xiaochengh commented May 6, 2022

Fixes #7893, which is a bug introduced by #7857.

(See WHATWG Working Mode: Changes for more details.)


/scripting.html ( diff )

@xiaochengh
Copy link
Contributor Author

@domenic PTAL

@domenic
Copy link
Member

domenic commented May 6, 2022

https://github.com/web-platform-tests/wpt/blob/master/html/dom/render-blocking/remove-element-unblocks-rendering.optional.html only seems to have tests for defer blocking="render" and async blocking="render", not for async and defer themselves. Are you sure this is tested?

@xiaochengh
Copy link
Contributor Author

remove-element-unblocks-rendering.optional.html tests that the element is not render-blocking after removing the blocking=render attribute, which implies that defer and async are not implicitly render-blocking. Does it count?

And AFAIK this is a long-established and very standard behavior so if this is violated then there should be a lot of other tests failing...

@zcorpan
Copy link
Member

zcorpan commented May 9, 2022

No, I think a test without blocking seems necessary since the adding and removing of blocking may be handled but the absence could be implemented incorrectly.

You should link to the test if it exists. If it doesn't, please write a new test. :)

@xiaochengh
Copy link
Contributor Author

I'm adding new tests via https://chromium-review.googlesource.com/c/chromium/src/+/3643218. PTAL

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request May 12, 2022
…ocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
aarongable pushed a commit to chromium/chromium that referenced this pull request May 12, 2022
…ocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643218
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1002737}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request May 12, 2022
…ocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643218
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1002737}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request May 12, 2022
…ocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643218
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1002737}
@xiaochengh
Copy link
Contributor Author

Friendly ping...

@zcorpan
Copy link
Member

zcorpan commented May 16, 2022

The test looks good to me!

@zcorpan zcorpan merged commit 76f47d3 into whatwg:main May 16, 2022
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 18, 2022
…licitly potentially render-blocking, a=testonly

Automatic update from web-platform-tests
Add a WPT for when a <script> is not implicitly potentially render-blocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643218
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1002737}

--

wpt-commits: 7f4089c1f0ba37dc51fb3a220f8719ff98863374
wpt-pr: 34038
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request May 25, 2022
…licitly potentially render-blocking, a=testonly

Automatic update from web-platform-tests
Add a WPT for when a <script> is not implicitly potentially render-blocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643218
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1002737}

--

wpt-commits: 7f4089c1f0ba37dc51fb3a220f8719ff98863374
wpt-pr: 34038
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
…ocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643218
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1002737}
NOKEYCHECK=True
GitOrigin-RevId: 0c63e935d875f7bbb2270333f54c9c698a8a0c79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

The conditions when a script element is implicitly potentially render-blocking are wrong
3 participants