-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make window.window/frames/self deal with no browsing context #4410
Conversation
I've reversed my opinion given tc39/ecma262#702 ( |
0c15092
to
2938b37
Compare
Tests: web-platform-tests/wpt#15720. Safari bug: https://bugs.webkit.org/show_bug.cgi?id=195406. |
2938b37
to
5e12e95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I guess blocked on TC39 and I agree it would be nice if they put the global this value somewhere besides the intrinsics table.
So all browsers seem to fail the new checks with "after discarded", is this intentional? They are passing in WebKit with my local patch to fix this though. |
…a=testonly Automatic update from web-platform-tests HTML: test WindowProxy self references For whatwg/html#4410. -- wpt-commits: 1a896b5997ef877e8f6e3005176857f615d58cd3 wpt-pr: 15720
@cdumez could you be more specific? When I run |
Oh indeed, I am unable to reproduce today. All tests indeed pass in Firefox and Chrome. Not sure why I was seeing different last week. Sorry about the noise. |
…a=testonly Automatic update from web-platform-tests HTML: test WindowProxy self references For whatwg/html#4410. -- wpt-commits: 1a896b5997ef877e8f6e3005176857f615d58cd3 wpt-pr: 15720
Language from tc39/ecma262#702. Tests: web-platform-tests/wpt#15720. Helps with #4363.
5e12e95
to
e9f6d61
Compare
I adjusted the text and commit message to align with the recent addition of (The amount of bookkeeping objects in the ECMAScript standard is too high.) |
…a=testonly Automatic update from web-platform-tests HTML: test WindowProxy self references For whatwg/html#4410. -- wpt-commits: 1a896b5997ef877e8f6e3005176857f615d58cd3 wpt-pr: 15720 UltraBlame original commit: 94c16b51d515e3fb32be07bf02d8832d97161b26
…a=testonly Automatic update from web-platform-tests HTML: test WindowProxy self references For whatwg/html#4410. -- wpt-commits: 1a896b5997ef877e8f6e3005176857f615d58cd3 wpt-pr: 15720 UltraBlame original commit: 94c16b51d515e3fb32be07bf02d8832d97161b26
…a=testonly Automatic update from web-platform-tests HTML: test WindowProxy self references For whatwg/html#4410. -- wpt-commits: 1a896b5997ef877e8f6e3005176857f615d58cd3 wpt-pr: 15720 UltraBlame original commit: 94c16b51d515e3fb32be07bf02d8832d97161b26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the difference here is that before "this Window object's browsing context" would sometimes be null, causing a spec crash, right? Please include that in the commit message since, coming back to this with fresh eyes, it's not obvious.
But yeah, spec text looks great! If a bit hilariously long.
Tests: ...
Helps with #4363.
/infrastructure.html ( diff )
/window-object.html ( diff )