HTML: test WindowProxy self references #15720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
domenic
reviewed
Mar 7, 2019
|
Thanks @domenic, should be good now! |
domenic
approved these changes
Mar 12, 2019
annevk
added a commit
to whatwg/html
that referenced
this pull request
Oct 2, 2019
Language from tc39/ecma262#702. Tests: web-platform-tests/wpt#15720. Helps with #4363.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Oct 16, 2019
Before this change these getters did not account for Window object's browsing context potentially being null, resulting in a conceptual crash. Language from tc39/ecma262#702. Tests: web-platform-tests/wpt#15720. Helps with #4363.
zcorpan
pushed a commit
to whatwg/html
that referenced
this pull request
Nov 6, 2019
Before this change these getters did not account for Window object's browsing context potentially being null, resulting in a conceptual crash. Language from tc39/ecma262#702. Tests: web-platform-tests/wpt#15720. Helps with #4363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/html#4410.