-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use logger #1748
refactor: use logger #1748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace all instances?
Yes, WIP |
bf064c3
to
e5ecf3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a src of how it looks with logger vs not logger
webpack-cli/packages/webpack-cli/lib/utils/logger.js Lines 3 to 9 in d3e2936
|
a1315b9
to
66e085b
Compare
2f12266
to
b5f5110
Compare
9168d2d
to
0514470
Compare
dc136b1
to
9003902
Compare
9003902
to
814033c
Compare
@jamesgeorge007 Can we fix CI? |
Looks like a random failure just retriggered CI. |
/cc @webpack/cli-team need review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 💯
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @snitin315 Please review the new changes. |
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
Follow up of #1740
Does this PR introduce a breaking change?
Other information
N/A