Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use logger #1748

Merged
merged 13 commits into from
Sep 3, 2020
Merged

refactor: use logger #1748

merged 13 commits into from
Sep 3, 2020

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
N/A

If relevant, did you update the documentation?
N/A

Summary
Follow up of #1740

Does this PR introduce a breaking change?

Other information
N/A

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace all instances?

@jamesgeorge007
Copy link
Member Author

replace all instances?

Yes, WIP

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a src of how it looks with logger vs not logger

@jamesgeorge007
Copy link
Member Author

Could you provide a src of how it looks with logger vs not logger

module.exports = {
error: (val) => console.error(`[webpack-cli] ${red(val)}`),
warn: (val) => console.warn(`[webpack-cli] ${yellow(val)}`),
info: (val) => console.info(`[webpack-cli] ${cyan(val)}`),
log: (val) => console.log(`[webpack-cli] ${val}`),
help: (val) => console.log(val),
};

@jamesgeorge007 jamesgeorge007 marked this pull request as ready for review August 19, 2020 08:26
@jamesgeorge007 jamesgeorge007 force-pushed the refactor/use-logger branch 3 times, most recently from 2f12266 to b5f5110 Compare August 19, 2020 15:21
evenstensberg
evenstensberg previously approved these changes Aug 19, 2020
@jamesgeorge007 jamesgeorge007 force-pushed the refactor/use-logger branch 3 times, most recently from dc136b1 to 9003902 Compare September 2, 2020 12:25
@alexander-akait
Copy link
Member

@jamesgeorge007 Can we fix CI?

@snitin315
Copy link
Member

Looks like a random failure just retriggered CI.

@alexander-akait
Copy link
Member

/cc @webpack/cli-team need review

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 💯

@webpack-bot
Copy link

@jamesgeorge007 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@snitin315 Please review the new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants