Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use console for logging #1740

Merged
merged 5 commits into from
Aug 12, 2020
Merged

chore: use console for logging #1740

merged 5 commits into from
Aug 12, 2020

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
chore, refactor

Did you add tests for your changes?
Already in place
If relevant, did you update the documentation?
NA
Summary
Align logging with console.

Does this PR introduce a breaking change?

Other information
#1681 (comment)

@snitin315 snitin315 requested a review from a team as a code owner August 11, 2020 05:37
@snitin315 snitin315 marked this pull request as draft August 11, 2020 06:11
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace all process.write/console.log/etc on logger in all places?

@snitin315
Copy link
Member Author

Yes, Work in progress.

@snitin315 snitin315 marked this pull request as ready for review August 12, 2020 09:11
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexander-akait alexander-akait merged commit 0ab7b50 into next Aug 12, 2020
@alexander-akait alexander-akait deleted the chore/logging branch August 12, 2020 14:15
@snitin315 snitin315 added this to Done (Phase 3) in GSoC 2020 Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
GSoC 2020
  
Done (Phase 3)
Development

Successfully merging this pull request may close these issues.

None yet

7 participants