-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use console for logging #1740
Conversation
19e2295
to
d75e079
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we replace all process.write
/console.log
/etc on logger in all places?
Yes, Work in progress. |
d75e079
to
1343131
Compare
1343131
to
7fefc85
Compare
7fefc85
to
e204a94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What kind of change does this PR introduce?
chore, refactor
Did you add tests for your changes?
Already in place
If relevant, did you update the documentation?
NA
Summary
Align logging with
console
.Does this PR introduce a breaking change?
Other information
#1681 (comment)