Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(info): throw an error if help or version is passed as an arg #1737

Merged
merged 4 commits into from
Aug 13, 2020

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
Generic test cases were added as part of #1694

If relevant, did you update the documentation?
N/A

Summary
Follow up of #1694

Does this PR introduce a breaking change?
Nope

Other information
N/A

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix it in all packages in this PR?

@jamesgeorge007
Copy link
Member Author

Can we fix it in all packages in this PR?

It is just serve and info that leverages arg-parser as of now.

alexander-akait
alexander-akait previously approved these changes Aug 7, 2020
evenstensberg
evenstensberg previously approved these changes Aug 8, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@jamesgeorge007 jamesgeorge007 removed the request for review from evenstensberg August 13, 2020 16:19
@jamesgeorge007 jamesgeorge007 merged commit c8ca878 into webpack:next Aug 13, 2020
@jamesgeorge007 jamesgeorge007 deleted the recognize-args branch August 13, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants