-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(serve): supplying help or version as an arg should throw #1694
Conversation
98636a9
to
e4058bd
Compare
e4058bd
to
ba54111
Compare
eb6aa70
to
aba0255
Compare
aba0255
to
ce04859
Compare
ce04859
to
58b4712
Compare
58b4712
to
5a650ee
Compare
bc4a998
to
13e26df
Compare
+1 only creates confusion, /cc @evilebottnawi |
Good question, I don't have the strong opinion here, but
|
In this case |
Yes we should remove |
@jamesgeorge007 can you update the PR to limit command count to 1? |
Couldn't agree more. |
98f7843
to
8f5292a
Compare
8f5292a
to
d1cbcae
Compare
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yup
If relevant, did you update the documentation?
N/A
Summary
webpack-cli serve help
should throw an error.serve
respects--no-color
flag.Does this PR introduce a breaking change?
Nope
Other information
N/A