wazuh-agentd stats IT #1039
Merged
wazuh-agentd stats IT #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnasselle
changed the title
JcabreraC
previously approved these changes
Feb 9, 2021
jnasselle
force-pushed
the
1034-agentd-stats-enhancement
branch
from
6ce217e
to
4865282
Compare
BraulioV
suggested changes
Feb 9, 2021
nmkoremblum
previously approved these changes
Feb 10, 2021
juliancnn
previously approved these changes
Feb 10, 2021
jmv74211
reviewed
Feb 10, 2021
There was a problem hiding this comment.
I see you have used a different function documentation format, although I think this is also interpretable by Sphinx. Please check this.
I have also seen several global declarations in the files that I think are unnecessary. I've indicated one, but I've seen several, so please take an overview of all of them and consider whether they are really necessary.
JcabreraC
previously approved these changes
Feb 10, 2021
jnasselle
dismissed stale reviews from JcabreraC, juliancnn, and nmkoremblum
via
e3a5c4e
jnasselle
requested review from
nmkoremblum,
JcabreraC,
juliancnn and
jmv74211
juliancnn
previously approved these changes
Feb 10, 2021
nmkoremblum
previously approved these changes
Feb 10, 2021
JcabreraC
previously approved these changes
Feb 10, 2021
BraulioV
previously approved these changes
Feb 11, 2021
jmv74211
previously approved these changes
Feb 11, 2021
- Fix some race condition in configuration tests - Add remote/file state tests - Add request method to RemotedSimulator
- Remove default read permission for file opening - Change doubles quotes to single quotes for strings - Add docstrings - Rename some functions and variables to be more intuitive - Change state file name in windows agent - Reorder some tests asserts
- Reorder imports - Change line limits from 80 to 120 - Unify duplicated funcions - Rename confusing variables and functions - Change some docstrings - Change way for reading and iterating thru files
- Remove unnecessary global statements - Fix some docstrings - Better approach to change internals values - Increase timeout in watching logs functions
jnasselle
dismissed stale reviews from jmv74211, BraulioV, JcabreraC, nmkoremblum, and juliancnn
via
e8acef9
jnasselle
force-pushed
the
1034-agentd-stats-enhancement
branch
from
e3a5c4e
to
e8acef9
Compare
jmv74211
approved these changes
Feb 24, 2021
BraulioV
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi team!
This PR aims to add integration test for
wazuh-agentdstats mechanism, that consist in:agent.state_intervalvaluesgetstate) and their correct valueTests
pycodestyle --max-line-length=120 --show-source --show-pep8 file.pyRegards,
Nico