forked from ruby/ruby
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from ruby:master #343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What was the end-user or developer problem that led to this PR? The old URL https://github.com/testdouble/standard is mentioned. ## What is your fix for the problem, implemented in this PR? This PR updates to the new URL https://github.com/standardrb/standard. rubygems/rubygems@eeafba72fc
Add comment for 7299c8c.
Fixes ruby/etc#22. Build failure when the ruby installed directory name contains spaces. ruby/etc@1ab19d5815
Commit messages written on GitHub's Web UI apparently use \r\n as a line separator and do not have a \n at the end of message, unlike those normally made with the git CLI. This breaks the expectation of the regexps used later.
(ruby/openssl#646) Add OpenSSL::PKey.new_raw_private_key, #raw_private_key and public equivalents. These methods are useful for importing and exporting keys that support "raw private/public key". Currently, OpenSSL implements X25519/X448 and Ed25519/Ed448 keys. [rhe: rewrote commit message] ruby/openssl@3f29525618 Co-authored-by: Bart de Water <bartdewater@gmail.com>
OpenSSL::Cipher#pkcs5_keyivgen (ruby/openssl#647) OpenSSL::Cipher#pkcs5_keyivgen should only be used when it is absolutely necessary for compatibility with ancient applications. Having an example can be misleading. We already have another example for OpenSSL::Cipher in which PBKDF2 is used to derive a key. As described in the rdoc of OpenSSL::Cipher#pkcs5_keyivgen, it is compatible with PKCS#5 PBES1 (PKCS#5 v1.5) only when used in combination of a hash function MD2, MD5, or SHA-1, and a cipher DES-CBC or RC2-CBC. This example uses MD5 as the hash function and combines it with AES. This is considered insecure and also using a non-standard technique to derive longer keys. ruby/openssl@e379cc0cca
Although MinGW provides this header but not the function, Windows version ruby provides the function. ruby/etc@f7fa1884fa
(ruby/irb#638) The caller should be the dialog itself, not Reline. ruby/irb@418c2b945e
…ring git sources Previously, when sorting and comparing git Gemfile vs lockfile sources during `bundler/setup` to figure out whether we need to re-resolve or not, we would try to find the default branch if nothing more specific was specified in the Gemfile. If the git cache has been deleted thought, that would fail. The error would still be swallowed (and the branch would simply not be displayed), but trying to clone would still generate the side effect of creating the parent folder for the clone. That could affect non-writable systems that don't expect `bundler/setup` to write to the filesystem at all. To fix this, override `Bundler::Source::Git#identifier` to use exclusively static information, so it does not even try to clone the repo nor generate any side effects. rubygems/rubygems@582eb2ef39
When we extract bigdecimal as bundled gems, this test will be failed with `make test-all`.
Closes [Feature #19729] Previously 2 bits of the flags on each RVALUE are reserved to store the number of GC cycles that each object has survived. This commit introduces a new bit array on the heap page, called age_bits, to store that information instead. This patch still reserves one of the age bits in the flags (the old FL_PROMOTED0 bit, now renamed FL_PROMOTED). This is set to 0 for young objects and 1 for old objects, and is used as a performance optimisation for the write barrier. Fetching the age_bits from the heap page and doing the required math to calculate if the object was old or not would slow down the write barrier. So we keep this bit synced in the flags for fast access.
To make the example code verbatim. Fixes #8061 ruby/getoptlong@85fe502916
Command line options should have higher precedence than the same options in shebang and `RUBYOPT`.
(ruby/irb#640) * Unpend rdoc dialog tests Without these tests, we don't have any coverage on autocompletion's rdoc dialog, which is what caused #638 to happen. * Pull ri doc on CI for the doc dialog test * Assert different screen result on CI and local machine ruby/irb@3ac96be660
RARRAY_PTR_USE now does the same things as RARRAY_PTR_USE_TRANSIENT.
RARRAY_CONST_PTR now does the same things as RARRAY_CONST_PTR_TRANSIENT.
We no longer need a reference to the array when allocating the buffer because we no longer allocate through the transient heap.
This commit applies ruby/rbs#1374.
Disallow: * Only year-month * Only year-month-day * Preceding whitespace * Trailing whitespace Fixes [Bug #19293]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )