Correct preferred_dialog_height's caller
#638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The caller should be the dialog itself, not Reline.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 12, 2023
(ruby/irb#638) The caller should be the dialog itself, not Reline. ruby/irb@418c2b945e
st0012
added a commit
that referenced
this pull request
Jul 12, 2023
Without these tests, we don't have any coverage on autocompletion's rdoc dialog, which is what caused #638 to happen.
This was referenced Jul 12, 2023
tompng
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Unpend rdoc dialog tests Without these tests, we don't have any coverage on autocompletion's rdoc dialog, which is what caused #638 to happen. * Pull ri doc on CI for the doc dialog test * Assert different screen result on CI and local machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caller should be the dialog itself, not Reline.
Fixes #637