Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oauth2 keys setup in installer #1847

Closed
wants to merge 4 commits into from
Closed

Add oauth2 keys setup in installer #1847

wants to merge 4 commits into from

Conversation

Cyclonecode
Copy link
Collaborator

Related issues

#1842

Short description and why it's useful

We can now use the installer to specify the oauth2 keys for magento2 integration.

Screenshots of visual changes before/after (if there are any)

(if you made any changes in the UI layer please provide before/after screenshots)

Screenshot of passed e2e tests (if you are using our standard setup as a backend)

(run yarn tests:e2e and paste the results. If you are not using our standard backend setup or demo.vuestorefront.io you can ommit this step)

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@pkarw
Copy link
Collaborator

pkarw commented Nov 8, 2018

@Cyclonecode I see that there is magento2.imgUrl endpoint missing in the installer setup
Could You please fix it?

Reference issue: vuestorefront/mage2vuestorefront#29 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants