Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the oauth2 keys setup in scripts/installer.js #1842

Closed
pkarw opened this issue Oct 10, 2018 · 1 comment
Closed

Add the oauth2 keys setup in scripts/installer.js #1842

pkarw opened this issue Oct 10, 2018 · 1 comment
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront

Comments

@pkarw
Copy link
Collaborator

pkarw commented Oct 10, 2018

What is the motivation for adding / enhancing this feature?

Currently, we do have a fast/simple integration path with Magento2: https://github.com/DivanteLtd/vue-storefront/blob/docs/docs/guide/installation/magento.md#fast-integration

Adding the questions for the vue-storefront-api/config/local.json:magento2:api section and putting the config there in the https://github.com/DivanteLtd/vue-storefront/blob/035f3a7bc70d5669fc431fddae1caf6369682e2e/core/scripts/installer.js#L225

will be awesome!

What are the acceptance criteria

  • the installer will ask the user for "url", "consumerKey", "consumerSecret", "accessToken", "accessTokenSecret"
  • the installer will update the vue-storefront-api/config/local.json
@pkarw pkarw added good first issue Tasks that requires just basic understanding of Vue Storefront feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can labels Oct 10, 2018
@pkarw
Copy link
Collaborator Author

pkarw commented Oct 10, 2018

This section - on m2 integration - shouldn't be required. It should ask You "would You like to perform initial data import from Magento2 instance?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront
Projects
None yet
Development

No branches or pull requests

1 participant