types(defineComponent): DefineComponent refactor #4465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/runtime-core/src/component.ts # packages/runtime-core/src/componentEmits.ts # packages/runtime-core/src/componentOptions.ts # test-dts/h.test-d.ts # yarn.lock
# Conflicts: # packages/runtime-core/src/componentOptions.ts
# Conflicts: # packages/runtime-core/src/component.ts # packages/runtime-core/src/componentOptions.ts # packages/runtime-core/src/componentProps.ts
# Conflicts: # packages/runtime-core/src/componentOptions.ts # packages/runtime-core/src/componentPublicInstance.ts # packages/runtime-dom/src/directives/vModel.ts # packages/runtime-dom/src/directives/vOn.ts # packages/runtime-dom/src/index.ts
# Conflicts: # packages/runtime-core/src/componentOptions.ts
…fineComponent_and_Component # Conflicts: # packages/runtime-core/src/apiDefineComponent.ts # packages/runtime-core/src/component.ts # packages/runtime-core/src/componentEmits.ts # packages/runtime-core/src/componentOptions.ts # packages/runtime-core/src/h.ts
…s/Merge_DefineComponent_and_Component # Conflicts: # packages/runtime-core/src/apiDefineComponent.ts
…_DefineComponent_and_Component # Conflicts: # packages/runtime-core/src/apiDefineComponent.ts # packages/runtime-core/src/componentOptions.ts # packages/runtime-core/src/componentPublicInstance.ts # test-dts/defineComponent.test-d.tsx
znck
reviewed
Aug 28, 2021
| * | ||
| * declare module '@vue/runtime-core' { | ||
| * interface GlobalDirectives { | ||
| * VTooltip |
There was a problem hiding this comment.
We should suggest using camelCase or kebab-case version of directive (without the v prefix); similar to local registration in component options.
| components?: Record<string, Component> | ||
| directives?: Record<string, Directive> | ||
| components?: LC | ||
| directives?: Directives |
There was a problem hiding this comment.
Should it be called LD to align with components option?
znck
reviewed
Aug 31, 2021
| Slots = {}, | ||
| // Allows to expose public API properties, this bypasses Data/Computed/Methods, | ||
| // easier to declare manually | ||
| Bindings extends Record<string, unknown> = {}, |
There was a problem hiding this comment.
Public API of a component is props, emits, slots and expose. What do you think about Expose being 4th param?
KaelWD
reviewed
Sep 6, 2021
| @@ -66,7 +90,8 @@ export type EmitFn< | |||
| ? (event: key, ...args: Args) => void | |||
| : (event: key, ...args: any[]) => void | |||
| }[Event] | |||
| > | |||
| >) & | |||
| EmitVModelUpdate<P> | |||
There was a problem hiding this comment.
Is this adding emit('update:foo') for every prop even if they don't have an emit declared for it?
KaelWD
reviewed
Sep 6, 2021
| @@ -22,16 +22,37 @@ import { isHmrUpdating } from './hmr' | |||
| import { DeprecationTypes, isCompatEnabled } from './compat/compatConfig' | |||
| import { toRaw } from '@vue/reactivity' | |||
|
|
|||
| export type Slot = (...args: any[]) => VNode[] | |||
| export type Slot = (...args: any[]) => VNode[] | VNode | |||
There was a problem hiding this comment.
h(Foo, () => {...} can return a single VNode but slots.default() is normalised so should always be VNode[]
KaelWD
reviewed
Sep 6, 2021
| resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.4.2.tgz#6d618640d430e3569a1dfb44f7d7e600ced3ee86" | ||
| integrity sha512-gzP+t5W4hdy4c+68bfcv0t400HVJMMd2+H9B7gae1nQlBzCqvrXX+6GL/b3GAgyTH966pzrZ70/fRjwAtZksSQ== | ||
|
|
||
| typescript@~4.3.5: |
There was a problem hiding this comment.
|
Closed in favor of #9556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to refactor
DefineComponentto merge it withComponenttypeBecause this will break the prev DefineComponent I've merged a few PR into this one
Merged PR
#2164
#2693
#3399
#2494