Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(defineComponent): Support emit when using functionalComponent #2494

Closed
wants to merge 3 commits into from

Conversation

pikax
Copy link
Member

@pikax pikax commented Oct 27, 2020

  describe('emit', () => {
    const MyComponent: FunctionalComponent<
      { foo: number },
      { ev: (a: string) => void }
    > = (_, _2) => {}

    defineComponent(MyComponent)
  })

@HcySunYang HcySunYang added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: types labels Mar 31, 2021
# Conflicts:
#	packages/runtime-core/src/apiDefineComponent.ts
@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB 32.7 kB 29.5 kB
vue.global.prod.js 132 kB 49.4 kB 44.3 kB

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.9 kB 17.2 kB
createSSRApp 50.7 kB 20 kB 18.2 kB
defineCustomElement 50.3 kB 19.7 kB 18 kB
overall 61.3 kB 23.7 kB 21.6 kB

@pikax pikax closed this Oct 21, 2023
@pikax pikax deleted the types/definecomponent_functional_emit branch October 21, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: types
Projects
Status: Rejected
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants