Non-local games check pass #857
Open
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #857 +/- ##
======================================
Coverage 97.8% 97.8%
======================================
Files 167 167
Lines 3263 3263
Branches 715 715
======================================
Hits 3193 3193
Misses 46 46
Partials 24 24 ☔ View full report in Codecov by Sentry. |
|
I have run all the checks 3 times after my commit without any failure. So I hope this problem has been resolved now. Although there is still a chance of failure, it has a very low probability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a brief description of the PR's purpose here. If your PR is supposed to fix an existing issue, use
a keyword to link your PR to the issue.
This PR is created to pass the check in the non-local games example. Since the optimal value for the chsh quantum probability is getting stuck in a suboptimal range, an approach to overcome this is running the check multiple times so as to maximize the chances to reach the optimal solution.
This has been discussed in detail in the discussionhere.
#Resolves #613
Changes
Notable changes that this PR has either accomplished or will accomplish. Feel free to add more lines to the itemized list
below.
np.around(chsh.quantum_value_lower_bound(), decimals=2)has been run multiple times (5).Checklist
Before marking your PR ready for review, make sure you checked the following locally. If this is your first PR, you might be notified of some workflow failures after a maintainer has approved the workflow jobs to be run on your PR.
Additional information is available in the documentation.
rufffor errors related to code style and formatting.pytest.Sphinxbuild can be checked locally for any failures related to your PRlinkcheckto check for broken links in the documentationdoctestto verify the examples in the function docstrings work as expected.