Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in non-local games tutorial #613

Open
purva-thakre opened this issue Jun 1, 2024 · 11 comments · May be fixed by #857
Open

Failure in non-local games tutorial #613

purva-thakre opened this issue Jun 1, 2024 · 11 comments · May be fixed by #857
Assignees
Labels
bug Something isn't working

Comments

@purva-thakre
Copy link
Collaborator

purva-thakre commented Jun 1, 2024

Vincent brought up this failure last week but we did not have a screenshot for it.

image

The difference between the expected and calculated values is large enough to think it is not due to the accuracy of the solvers.

Interestingly, this failure might happen only for Python 3.12.

@purva-thakre purva-thakre added the bug Something isn't working label Jun 1, 2024
@vprusso
Copy link
Owner

vprusso commented Jun 2, 2024

Nice catch. Yeah, don't quite know why this occurs in the docs only. I am able to run Python 3.12 on Mac with that snippet which yields (correctly) the 0.85 figure.

I wonder if it's somehow about how the docs are sequentially run and weather there might be something residual in the namespace that runs somewhat strangely in the docs for 3.12.

Good to have caught it, but definitely a bit perplexing!

@purva-thakre
Copy link
Collaborator Author

purva-thakre commented Jun 2, 2024

I am able to run Python 3.12 on Mac with that snippet which yields (correctly) the 0.85 figure.

I remember Nate saying something about a difference in a local macOS device vs. what's used by the workflows. I had unintentionally created a bug in mitiq by trying to please mypy. This led to a test passing locally on his device but the CI/CD would fail all the time.

If you see this code block passing locally on a macOS device, maybe it's a similar issue where the resources used in the runner differ from what's used on your local device. I know we don't use mypy yet but it could still be related to the accuracy of the solvers and available resources?

unitaryfund/mitiq#2127

I did notice this failure twice yesterday. python3.11 would pass while python3.10 got canceled because python3.12 saw the failure in the screenshot.

@vprusso
Copy link
Owner

vprusso commented Jun 3, 2024

Ah, nice catch. And good point! It's probably something subtle like that. Which is good as it doesn't appear to be a breaking change, but definitely a bit frustrating as it's not clear where/how the state is being mangled here. Thanks for catching this!

@vprusso
Copy link
Owner

vprusso commented Jul 13, 2024

I think we can close this one out, but I'll wait for @purva-thakre to confirm whether I might be missing any reason to not do so.

@purva-thakre
Copy link
Collaborator Author

Did it resolve itself? I have not seen the failure after I created this issue.

@vprusso
Copy link
Owner

vprusso commented Jul 15, 2024

It has been a while since I've noticed the issue. If this one does rear its head again, we can go ahead and reopen the issue. For now, I'll tempt fate and close (which I'm sure will trigger the universe to throw the error again inadvertently).

@vprusso vprusso closed this as completed Jul 15, 2024
@vprusso
Copy link
Owner

vprusso commented Jul 17, 2024

Opening back up:
https://github.com/vprusso/toqito/actions/runs/9973551751/job/27559130957

@vprusso vprusso reopened this Jul 17, 2024
@vprusso
Copy link
Owner

vprusso commented Oct 4, 2024

Okay, I'm going to close this yet again based on some recent work on the NLG module. Hoping that I won't need to open this back up :)

@vprusso vprusso closed this as completed Oct 4, 2024
@purva-thakre purva-thakre reopened this Oct 11, 2024
@purva-thakre
Copy link
Collaborator Author

reopening due to #835 (comment)

@Shivansh20128
Copy link
Contributor

I want to work on this issue. Can you please assign this to me?
Thank you

@vprusso
Copy link
Owner

vprusso commented Oct 11, 2024

Absolutely! Assigned!

@Shivansh20128 Shivansh20128 linked a pull request Oct 12, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants