(#382) Update types to allow for % where appropriate

[rgardner4012]

Pull Request (PR) description

Updates systemd::journald RuntimeMaxUse=, RuntimeKeepFree=,SystemMaxUse=, SystemKeepFree=, types to support using percentages

This Pull Request (PR) fixes the following issues

Fixes #382

[kenyon]

Are percentages really allowed? I see systemd/systemd#9548 (a request for enhancement that is still open) and https://bugzilla.redhat.com/show_bug.cgi?id=874631

The documentation doesn't actually say that you can use percentages: https://www.freedesktop.org/software/systemd/man/latest/journald.conf.html#SystemMaxUse=

I tried setting SystemMaxUse=100% and restarting systemd-journald. It didn't complain, but didn't seem to do anything either. The reported max size from systemctl status system-journald was the same regardless of this setting.

[rgardner4012]

Are percentages really allowed? I see systemd/systemd#9548 (a request for enhancement that is still open) and https://bugzilla.redhat.com/show_bug.cgi?id=874631

The documentation doesn't actually say that you can use percentages: https://www.freedesktop.org/software/systemd/man/latest/journald.conf.html#SystemMaxUse=

I was going off of this in your second link

"The first pair defaults to 10% and the second to 15% of the size of the respective file system, but each value is capped to 4G. If the file system is nearly full and either SystemKeepFree= or RuntimeKeepFree= are violated when systemd-journald is started, the limit will be raised to the percentage that is actually free. This means that if there was enough free space before and journal files were created, and subsequently something else causes the file system to fill up, journald will stop using more space, but it will not be removing existing files to reduce the footprint again, either. Also note that only archived files are deleted to reduce the space occupied by journal files. This means that, in effect, there might still be more space used than SystemMaxUse= or RuntimeMaxUse= limit after a vacuuming operation is complete."

[kenyon]

Right, but that doesn't say that you can use percentages. Also https://lists.freedesktop.org/archives/systemd-devel/2014-October/023596.html which was in reply to https://lists.freedesktop.org/archives/systemd-devel/2014-September/023262.html.

[rgardner4012]

You are correct, it reads the values without complaining but doesn't actually use them. What is the best way to get this backed out? Do I need to open a PR with the change reverted?

[kenyon]

The revert button here does it: #383 (comment)