Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd::journald SystemMaxUse=, SystemKeepFree=,RuntimeMaxUse=, RuntimeKeepFree=, support using %'s instead of explicit sizing #382

Closed
rgardner4012 opened this issue Oct 26, 2023 · 0 comments · Fixed by #383 or #387

Comments

@rgardner4012
Copy link
Contributor

Journald.conf supports using %'s in certain settings, but your types only allow for (K|M|G|T|P|E). Using a % in an expected value throws an error.
"parameter 'journald_settings' entry 'SystemMaxUse' expects a match for Variant[Pattern[/^[0-9]+(K|M|G|T|P|E)?$/], Systemd::JournaldSettings::Ensure = Struct[{'ensure' => Enum['absent', 'present']}]], got '10%"

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: all
  • Ruby: all
  • Distribution: all
  • Module version: all

How to reproduce (e.g Puppet code you use)

Set a value to a '%' in hiera and puppet fails to apply

What are you seeing

"parameter 'journald_settings' entry 'SystemMaxUse' expects a match for Variant[Pattern[/^[0-9]+(K|M|G|T|P|E)?$/], Systemd::JournaldSettings::Ensure = Struct[{'ensure' => Enum['absent', 'present']}]], got '10%"

What behaviour did you expect instead

For it to update the /etc/systemd/journald.conf file appropriately

Output log

"parameter 'journald_settings' entry 'SystemMaxUse' expects a match for Variant[Pattern[/^[0-9]+(K|M|G|T|P|E)?$/], Systemd::JournaldSettings::Ensure = Struct[{'ensure' => Enum['absent', 'present']}]], got '10%"

Any additional information you'd like to impart

rgardner4012 pushed a commit to rgardner4012/puppet-systemd that referenced this issue Oct 26, 2023
bastelfreak added a commit that referenced this issue Oct 26, 2023
…settings

(#382) Update types to allow for % where appropriate
rgardner4012 added a commit to rgardner4012/puppet-systemd that referenced this issue Oct 26, 2023
kenyon added a commit that referenced this issue Oct 26, 2023
…n_journald_settings

Revert "(#382) Update types to allow for % where appropriate"
pfhonore pushed a commit to pfhonore/puppet-systemd that referenced this issue Feb 5, 2024
pfhonore pushed a commit to pfhonore/puppet-systemd that referenced this issue Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants