Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service_enable parameter to sentinel.pp #307

Merged
merged 4 commits into from
Apr 17, 2019
Merged

Add service_enable parameter to sentinel.pp #307

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7879c16
Add service_enable parameter to sentinel.pp so that hiera can be used…
rschemm-godaddy Apr 9, 2019
cc886a8
Add service_enable parameter to sentinel.pp so that hiera can be used…
rschemm-godaddy Apr 9, 2019
35365ba
Merge branch 'master' of https://github.com/rschemm/puppet-redis
rschemm-godaddy Apr 10, 2019
6f1a9af
adding datatype for new parameter service_enable
rschemm-godaddy Apr 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion manifests/sentinel.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,11 @@
#
# Default: redis
#
# [*service_enable*]
# Enable the service at boot time.
#
# Default: true
#
# [*working_dir*]
# The directory into which sentinel will change to avoid mount
# conflicts.
Expand Down Expand Up @@ -190,6 +195,7 @@
$service_group = $::redis::params::service_group,
$service_name = $::redis::params::sentinel_service_name,
$service_ensure = $::redis::params::service_ensure,
$service_enable = $::redis::params::service_enable,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a datatype for the new parameter and a unit test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datatype added and email address updated, good catch.

$service_user = $::redis::params::service_user,
$working_dir = $::redis::params::sentinel_working_dir,
$notification_script = $::redis::params::sentinel_notification_script,
Expand Down Expand Up @@ -253,7 +259,7 @@

service { $service_name:
ensure => $service_ensure,
enable => $::redis::params::service_enable,
enable => $service_enable,
hasrestart => $::redis::params::service_hasrestart,
hasstatus => $::redis::params::service_hasstatus,
}
Expand Down