-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service_enable parameter to sentinel.pp #307
Conversation
… to enable/disable the service at boot time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Hi @rschemm, thanks for the PR. Can you please check the used email address in your commit? It isn't associated with your github account. |
manifests/sentinel.pp
Outdated
@@ -190,6 +195,7 @@ | |||
$service_group = $::redis::params::service_group, | |||
$service_name = $::redis::params::sentinel_service_name, | |||
$service_ensure = $::redis::params::service_ensure, | |||
$service_enable = $::redis::params::service_enable, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a datatype for the new parameter and a unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Datatype added and email address updated, good catch.
… to enable/disable the service at boot time.
Pull Request (PR) description
Add service_enable parameter to sentinel.pp so that the state of sentinel on boot can be controlled independently of redis.
This Pull Request (PR) fixes the following issues