Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency of the legacy client code from pkg/cmd directory part 1 #6469

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 6, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6190

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet changed the title Remove dependency of the legacy client code. Remove dependency of the legacy client code from pkg/cmd directory Jul 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Merging #6469 (4a08bc7) into main (e54a8af) will decrease coverage by 0.04%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##             main    #6469      +/-   ##
==========================================
- Coverage   60.18%   60.15%   -0.04%     
==========================================
  Files         229      229              
  Lines       24215    24226      +11     
==========================================
- Hits        14575    14572       -3     
- Misses       8632     8643      +11     
- Partials     1008     1011       +3     
Impacted Files Coverage Δ
pkg/cmd/cli/backup/create.go 66.92% <64.28%> (-1.20%) ⬇️

... and 4 files with indirect coverage changes

@blackpiglet blackpiglet force-pushed the 6190_fix branch 5 times, most recently from a98bebb to dbd65d7 Compare July 7, 2023 09:00
@blackpiglet blackpiglet changed the title Remove dependency of the legacy client code from pkg/cmd directory Remove dependency of the legacy client code from pkg/cmd directory part 1 Jul 7, 2023
@blackpiglet blackpiglet force-pushed the 6190_fix branch 3 times, most recently from c871066 to 6779436 Compare July 11, 2023 08:59
@blackpiglet blackpiglet marked this pull request as ready for review July 11, 2023 09:00
@blackpiglet blackpiglet force-pushed the 6190_fix branch 6 times, most recently from 06624eb to ab3caa0 Compare July 13, 2023 12:56
ywk253100
ywk253100 previously approved these changes Jul 14, 2023
Signed-off-by: Xun Jiang <jxun@vmware.com>
@Lyndon-Li Lyndon-Li merged commit dfd7970 into vmware-tanzu:main Jul 14, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate how to remove the generated legacy client-go code.
4 participants