Investigate how to remove the generated legacy client-go code.

[blackpiglet]

v1.12

• Remove from pkg/cmd directory part 1 - Remove dependency of the legacy client code from pkg/cmd directory part 1 #6469
• Remove from pkg/cmd directory part 2.

v1.13

• Remove from pkg/plugin directory.
• Remove from the rest directories.
• Check with the community.
• Record in the release note.

v1.15

• Remove the pkg/generated directory.
• Mention the change in the release note.

Backlog

• Update hack/test.sh to update the excluded packages.

Describe the problem/challenge you have

Since all Velero controllers already used the controller-runtime framework, Velero should consider whether to remove the legacy client-go code.
Investigate where those legacy codes are still used, and check whether it's possible to remove those codes.

Describe the solution you'd like

Anything else you would like to add:

Environment:

• Velero version (use velero version):
• Kubernetes version (use kubectl version):
• Kubernetes installer & version:
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

• 👍 for "The project would be better with this feature added"
• 👎 for "This feature will not enhance the project in a meaningful way"

[blackpiglet]

v1.12 planned tasks are already done.

[blackpiglet]

After discussion, the agreement is that the pkg/generated should be deprecated first, and then deleted.
The deprecation process is proposed by PR #5532.
After PR #5532 is merged, I will follow that PR to start the deprecation process.

[blackpiglet]

Need to add this deprecation notice in the v1.13 release note.

[blackpiglet]

v1.13's jobs are done for this task. Remove from the v1.13 milestone.

[blackpiglet]

@mateusoliveira43
I updated the task list.
After the release-1.14 is cut, we are good to go to remove the generated client code.

[mateusoliveira43]

@blackpiglet thanks!

should pkg/plugin/generated directory also be removed, or just pkg/generated directory?

[blackpiglet]

We should keep the pkg/plugin/generated directory.
The protobuf binary generated the directory. That is not related to the go-client.

[blackpiglet]

@sseago @Lyndon-Li @mateusoliveira43 @shubham-pampattiwar @anshulahuja98
Is this issue also applicable to the deprecation process?

[kaovilai]

If this is only dev facing, not user facing, it may not have to be as strict.

[blackpiglet]

OK.
I will create a PR to address this issue.

[sseago]

Also, we did deprecate this in 1.13:

* The generated k8s clients, informers, and listers are deprecated in the Velero v1.13 release. They are put in the Velero repository's pkg/generated directory. According to the n+2 supporting policy, the deprecated are kept for two more releases. The pkg/generated directory should be deleted in the v1.15 release.

The one thing we didn't do was vote on it in an issue, but I think that's fine here. We're still following the more important part which is deprecating 2 releases before removal, especially as @kaovilai said, since this isn't a user-facing feature.