Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re: proposal to remove pkg/generated from velero, remove the dependency from e2e tests #1221

Closed
weshayutin opened this issue Nov 8, 2023 · 6 comments · Fixed by #1492
Closed

Re: proposal to remove pkg/generated from velero, remove the dependency from e2e tests #1221

weshayutin opened this issue Nov 8, 2023 · 6 comments · Fixed by #1492
Assignees
@mateusoliveira43
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
OADP-1.4

Comments

@weshayutin
Copy link
Contributor

Only developers will use GitHub issues for development purposes

agree
@weshayutin
Copy link
Contributor Author

Xun
Propose to delete pkg/generated directory in v1.13:
Issue: vmware-tanzu/velero#6190
Slack: https://kubernetes.slack.com/archives/C021GPR1L3S/p1699276218067089
Decision: we can deprecate it first (keep it updated), and follow the guideline to remove it (We’ll merge 5532, probably n+2) communicate the deprecation via the releasenote or code comment

@weshayutin weshayutin added this to the OADP-1.4 milestone Dec 5, 2023
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 5, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 4, 2024
@mateusoliveira43
Copy link
Contributor

unstale

@mateusoliveira43
Copy link
Contributor

/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Apr 4, 2024
@mateusoliveira43 mateusoliveira43 mentioned this issue Apr 4, 2024
Closed
3 tasks
@mateusoliveira43 mateusoliveira43 mentioned this issue Aug 14, 2024
Merged
@mateusoliveira43
Copy link
Contributor

Velero PR vmware-tanzu/velero#8114 (vmware-tanzu/velero#7627)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mateusoliveira43 mateusoliveira43

Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
OADP-1.4
3 participants
@weshayutin @openshift-bot @mateusoliveira43