Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Pod Volume Backup resource/controller to the Kubebuilder framework #3505

Closed
wants to merge 27 commits into from
Closed

Convert Pod Volume Backup resource/controller to the Kubebuilder framework #3505

wants to merge 27 commits into from

Conversation

codegold79
Copy link
Contributor

Summary of change

Convert Pod Volume Backup resource/controller to the Kubebuilder framework. Write Ginkgo tests.

Fixes #3454

Please indicate you've done the following:

@codegold79
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes labels Feb 25, 2021
@codegold79 codegold79 force-pushed the 3454-convert-pod-volume-backup-controller-to-kubebuilder-framwork branch from b7e0fdf to a229524 Compare February 25, 2021 21:54
@codegold79

This comment has been minimized.

Sign in to view
@carlisia
Copy link
Contributor

@codegold79 I have some work to unblock things for our release, and also argh meetings, but will try to get this by EOD today.

@carlisia
Copy link
Contributor

Also: I'm curious if you cd into the controller package and run go test ./... if you'd get any error message that is different and helpful.

@codegold79

This comment has been minimized.

Sign in to view
@codegold79

This comment has been minimized.

Sign in to view
@codegold79

This comment has been minimized.

Sign in to view
@codegold79 codegold79 changed the title WIP Convert Pod Volume Backup resource/controller to the Kubebuilder framework Convert Pod Volume Backup resource/controller to the Kubebuilder framework Mar 5, 2021
@codegold79 codegold79 force-pushed the 3454-convert-pod-volume-backup-controller-to-kubebuilder-framwork branch from 1def94a to 0f040b5 Compare March 5, 2021 19:19
codegold79 and others added 9 commits March 5, 2021 11:49
@codegold79
Initial transfer of PodVolumeBackup controller logic
70eec61 
from old way to Kubebuilder framwork.

Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79
Incomplete Ginkgo tests
7766fff 
Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79
Delete old pod volume backup controller test
699f739 
Signed-off-by: F. Gold <fgold@vmware.com>
@chrisjs @codegold79
Add Glob to FileSystem interface and impls
445767f 
Signed-off-by: Chris Schaefer <cschaefer@vmware.com>
@codegold79
Add secret and clean up server.go
f69d6b5 
Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79
Create restic executer, set test fields
a2cde4e 
Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79
Fix tests, edit copyright format
c0b0bc2 
Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79
Break down Reconcile(...) method to smaller ones
49e3c17 
Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79
Add test assertions that check if PVBs were processed or not
67f79d4 
Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79 codegold79 force-pushed the 3454-convert-pod-volume-backup-controller-to-kubebuilder-framwork branch from efc4943 to 67f79d4 Compare March 5, 2021 19:53
@codegold79
Run go mod tidy
24f0f5f 
Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79
Regenerate CRDs
b75852a 
Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79
Remove cyclic dependency from fake_restic_executer.go; minor formatting
8bd5a30 
Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79 codegold79 force-pushed the 3454-convert-pod-volume-backup-controller-to-kubebuilder-framwork branch from 0257158 to 8bd5a30 Compare March 6, 2021 03:58
@codegold79 codegold79 marked this pull request as ready for review March 6, 2021 04:06
@codegold79
Merge remote-tracking branch 'origin/main' into 3454-convert-pod-volu…
a7169d6 
…me-backup-controller-to-kubebuilder-framwork
@codegold79
Update CRDs with 'make update'
9c8b9d2 
Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79
Copy link
Contributor Author

@dsu-igeek @zubron I have fixed the merge conflicts and ran make update.

@dsu-igeek dsu-igeek self-requested a review July 30, 2021 18:55
@zubron zubron mentioned this pull request Aug 20, 2021
Closed
@reasonerjt reasonerjt modified the milestones: v1.7.0, v1.8.0 Aug 25, 2021
@codegold79 codegold79 changed the title Convert Pod Volume Backup resource/controller to the Kubebuilder framework WIP Convert Pod Volume Backup resource/controller to the Kubebuilder framework Aug 27, 2021
@codegold79 codegold79 marked this pull request as draft August 27, 2021 15:34
@codegold79
Copy link
Contributor Author

I moved this PR to WIP because I'd like to fix the namespace issue detailed in #4052.

@codegold79
Copy link
Contributor Author

codegold79 commented Sep 24, 2021 •
edited
Loading

Added commit that will ensure that kubebuilder (controller-runtime) controllers will only act on resources that appear in their own namespace. See #4052 (comment) for more details.

@codegold79 codegold79 marked this pull request as ready for review September 24, 2021 00:02
@codegold79 codegold79 changed the title WIP Convert Pod Volume Backup resource/controller to the Kubebuilder framework Convert Pod Volume Backup resource/controller to the Kubebuilder framework Sep 24, 2021
@codegold79 codegold79 mentioned this pull request Oct 8, 2021
Closed
@codegold79 codegold79 modified the milestones: Prioritized issues, v1.8.0 Oct 20, 2021
@reasonerjt
Copy link
Contributor

As we are evaulating using kubebuilder v3 to refactor the controllers, let's hold this PR as it's likely to be reworked.

@blackpiglet
Copy link
Contributor

@codegold79
PR #4382 is merged. I think this PR is not blocked anymore. Please go on with your work. Sorry for the inconvenience.

@reasonerjt reasonerjt modified the milestones: Prioritized issues, v1.8.0 Nov 29, 2021
@codegold79
Copy link
Contributor Author

This PR was so behind, I created a new one that is based on the main branch. See PR #4436.

@codegold79 codegold79 closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zubron zubron Awaiting requested review from zubron

@dsu-igeek dsu-igeek Awaiting requested review from dsu-igeek

@blackpiglet blackpiglet Awaiting requested review from blackpiglet

@reasonerjt reasonerjt Awaiting requested review from reasonerjt

Assignees

@codegold79 codegold79

Labels
has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Convert Pod Volume Backup resource/controller to the Kubebuilder framework
5 participants
@codegold79 @carlisia @reasonerjt @blackpiglet @chrisjs