Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Pod Volume Backup resource/controller to the Kubebuilder framework #3505

Closed
wants to merge 27 commits into from
Closed

Convert Pod Volume Backup resource/controller to the Kubebuilder framework #3505

wants to merge 27 commits into from

Commits on Mar 5, 2021

  1. Initial transfer of PodVolumeBackup controller logic 

    from old way to Kubebuilder framwork.

Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    70eec61 View commit details
    Browse the repository at this point in the history

  2. Incomplete Ginkgo tests 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    7766fff View commit details
    Browse the repository at this point in the history

  3. Delete old pod volume backup controller test 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    699f739 View commit details
    Browse the repository at this point in the history

  4. Add Glob to FileSystem interface and impls 

    Signed-off-by: Chris Schaefer <cschaefer@vmware.com>
    @chrisjs @codegold79
    chrisjs authored and codegold79 committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    445767f View commit details
    Browse the repository at this point in the history

  5. Add secret and clean up server.go 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    f69d6b5 View commit details
    Browse the repository at this point in the history

  6. Create restic executer, set test fields 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    a2cde4e View commit details
    Browse the repository at this point in the history

  7. Fix tests, edit copyright format 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    c0b0bc2 View commit details
    Browse the repository at this point in the history

  8. Break down Reconcile(...) method to smaller ones 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    49e3c17 View commit details
    Browse the repository at this point in the history

  9. Add test assertions that check if PVBs were processed or not 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    67f79d4 View commit details
    Browse the repository at this point in the history

  10. Run go mod tidy 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    24f0f5f View commit details
    Browse the repository at this point in the history

  11. Regenerate CRDs 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    b75852a View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2021

  1. Remove cyclic dependency from fake_restic_executer.go; minor formatting 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    8bd5a30 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Add more detail to RunBackup method comment 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    b541749 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Use builder functions in tests to reduce duplication 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    949905a View commit details
    Browse the repository at this point in the history

  2. Make copyright The Velero Contributors more consistent 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    95902c8 View commit details
    Browse the repository at this point in the history

  3. Make copyright The Velero Contributors more consistent 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    02a1b7c View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Merge remote-tracking branch 'origin/main' into 3454-convert-pod-volu… 

    …me-backup-controller-to-kubebuilder-framwork
    @codegold79
    codegold79 committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    d9db0bd View commit details
    Browse the repository at this point in the history

  2. Update PVB tests to include restic credentials changes 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    c4983a4 View commit details
    Browse the repository at this point in the history

  3. Make copyright The Velero Contributors more consistent 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    3110eea View commit details
    Browse the repository at this point in the history

  4. Fix cyclic import lint check failure 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    c5ba28e View commit details
    Browse the repository at this point in the history

  5. Run update script for CRDs 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    609a130 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. Avoid cyclic import error without abusing interfaces 

    Move the fake_restic_executor.go to be part of the pkg/restic/mocks package and the import cycle error
goes away.

Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    c7f4913 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into 3454-convert-pod-volu… 

    …me-backup-controller-to-kubebuilder-framwork
    @codegold79
    codegold79 committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    8a8a830 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Merge remote-tracking branch 'origin/main' into 3454-convert-pod-volu… 

    …me-backup-controller-to-kubebuilder-framwork
    @codegold79
    codegold79 committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    a7169d6 View commit details
    Browse the repository at this point in the history

  2. Update CRDs with 'make update' 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    9c8b9d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Merge remote-tracking branch 'origin/main' into 3454-convert-pod-volu… 

    …me-backup-controller-to-kubebuilder-framwork
    @codegold79
    codegold79 committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    fb8173a View commit details
    Browse the repository at this point in the history

  2. Controller-runtime controllers only watch for resources in own namespace 

    Signed-off-by: F. Gold <fgold@vmware.com>
    @codegold79
    codegold79 committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    e6e00aa View commit details
    Browse the repository at this point in the history