-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate more backup action tests, remove obsolete test code #1564
Conversation
Signed-off-by: Steve Kriss <krisss@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Steve Kriss <krisss@vmware.com>
found a little more code that could be removed, added a new commit |
Still 👍 |
@nrb PTAL when you get a chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Did you want it squashed, @skriss?
Yeah, please! |
* upstream/master: (220 commits) Add restic instructions for Enterprise PKS (vmware-tanzu#1579) Adding Adnan to the team Discontinue use of excerpt separators in blog posts. (vmware-tanzu#1578) migrate PV snapshot tests migrate more backup action tests, remove obsolete test code (vmware-tanzu#1564) hide server commands in velero CLI (vmware-tanzu#1561) Fix test comparison remove glog (vmware-tanzu#1559) move issue-template-gen from docs/ to hack/ (vmware-tanzu#1558) update go-plugin to latest for bug fix (vmware-tanzu#1560) fix panic when processing DeleteBackupRequest objs without labels (vmware-tanzu#1556) Refactoring for backup item action tests (vmware-tanzu#1545) Support for multiple AWS profiles (vmware-tanzu#1548) add a link of velero plugin for alibabacloud to support-matrix docs fixes inlining of command in GCP setup docs (vmware-tanzu#1547) Signed-off-by: David Coons <coonsd@oregonstate.edu> (vmware-tanzu#1550) Add cmd to list plugins (vmware-tanzu#1535) Add ability to use wildcard in includes/excludes Initial pkg/backup test refactoring (vmware-tanzu#1532) Only run CI when relevant files have changed ...
Signed-off-by: Steve Kriss krisss@vmware.com
Followup to #1545, moves over one additional test case and a test helper, and deletes a bunch of now-obsolete code from the old tests.