Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes inlining of command in GCP setup docs #1547

Merged
merged 2 commits into from
Jun 6, 2019

Conversation

prydonius
Copy link
Contributor

Currently this command gets inlined in the docs site, when it should appear in its own block.

Screen Shot 2019-06-05 at 16 27 43

Let me know if this is not the right place to make this fix, or if I need to replicate the fix in the other version folders?

Signed-off-by: Adnan Abdulhussein aadnan@vmware.com

Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
@carlisia
Copy link
Contributor

carlisia commented Jun 6, 2019

Good catch!

Yes, please do the same for the version in master, and scan the folders for the other versions as well.

@skriss
Copy link
Member

skriss commented Jun 6, 2019

I'd say making the fix for master/ and v1.0.0/ is sufficient - going forward there's no real need to update pre-1.0 docs, we're just keeping them around for reference.

Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
@prydonius
Copy link
Contributor Author

thanks @carlisia @skriss - updated to fix the master folder too!

@carlisia carlisia merged commit f1319be into vmware-tanzu:master Jun 6, 2019
@prydonius prydonius deleted the fix-command-in-gcp-docs branch June 7, 2019 15:54
jessestuart added a commit to jessestuart/velero that referenced this pull request Jun 18, 2019
* upstream/master: (220 commits)
  Add restic instructions for Enterprise PKS (vmware-tanzu#1579)
  Adding Adnan to the team
  Discontinue use of excerpt separators in blog posts. (vmware-tanzu#1578)
  migrate PV snapshot tests
  migrate more backup action tests, remove obsolete test code (vmware-tanzu#1564)
  hide server commands in velero CLI (vmware-tanzu#1561)
  Fix test comparison
  remove glog (vmware-tanzu#1559)
  move issue-template-gen from docs/ to hack/ (vmware-tanzu#1558)
  update go-plugin to latest for bug fix (vmware-tanzu#1560)
  fix panic when processing DeleteBackupRequest objs without labels (vmware-tanzu#1556)
  Refactoring for backup item action tests (vmware-tanzu#1545)
  Support for multiple AWS profiles (vmware-tanzu#1548)
  add a link of velero plugin for alibabacloud to support-matrix docs
  fixes inlining of command in GCP setup docs (vmware-tanzu#1547)
  Signed-off-by: David Coons <coonsd@oregonstate.edu> (vmware-tanzu#1550)
  Add cmd to list plugins (vmware-tanzu#1535)
  Add ability to use wildcard in includes/excludes
  Initial pkg/backup test refactoring (vmware-tanzu#1532)
  Only run CI when relevant files have changed
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants