[Crossport]Rely on only container name while parsing feature flags (#422) #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#422) The PR ensures that the plugin uses only the container name to determine velero container. Signed-off-by: Deepak Kinni <dkinni@vmware.com>
|
Can you add a release note? |
@deepakkinni ^^ |
|
LGTM other than that. |
doesn't have user facing changes, it's internal. Not sure what release note needs to be added. |
|
Sorry, some of the pre-check tests are failing for this PR ! Please check the Jenkins job for more details |
|
@deepakkinni This is actually a user facing bug. You can add "Add support for velero image with sha tag". |
lintongj
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR ensures that the plugin uses only the container name to determine velero container.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #421
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Signed-off-by: Deepak Kinni dkinni@vmware.com