Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flags are not processed when a velero sha256 image is used for velero install. #421

Closed
poojitab opened this issue Nov 29, 2021 · 0 comments · Fixed by #422
Closed
Assignees

Comments

@poojitab
Copy link

Describe the bug

  • When velero sha256 image is used for velero install by OADP operator 0.4.2, feature flags provided for this container are not captured. Hence "EnableLocalMode" is neither parsed/set in configMap 'velero-vsphere-plugin-feature-states' by vSphere plugin.
  • Velero sha256 image used was: velero/velero@sha256:934dae8b2e17b4298bca95f45ec3620a283647297fb8ba8c0f5977e8238a97ee
  • In this code (
    if containerName == container.Name && containerName == utils.GetComponentFromImage(container.Image, constants.ImageContainerComponent) {
    ) , Looks like container name "velero" is matched for while looking for feature flags whereas in the above case "velero@sha256" is received.
  • Velero install command:
    • root@irv-vm-90-66:~# ./velero install --namespace velero-test --image "velero/velero@sha256:934dae8b2e17b4298bca95f45ec3620a283647297fb8ba8c0f5977e8238a97ee" --no-secret --no-default-backup-location --use-volume-snapshots=false --plugins vsphereveleroplugin/velero-plugin-for-vsphere:v1.3.0 --features EnableLocalMode

To Reproduce

  • Set "EnableLocalMode" feature flag in velero deployment.
  • Use velero sha256 image for velero install.

Expected behavior

  • When velero sha256 image is used, feature flags should be processed as it was done before and corresponding value should be set in 'velero-vsphere-plugin-feature-states' configMap in velero namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants