Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove usage of querystring #4342

Merged
merged 2 commits into from
Jul 21, 2021
Merged

chore: remove usage of querystring #4342

merged 2 commits into from
Jul 21, 2021

Conversation

benmccann
Copy link
Collaborator

Description

Fixes #4341

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jul 21, 2021
@Shinigami92 Shinigami92 added p1-chore Doesn't change code behavior (priority) and removed p2-nice-to-have Not breaking anything but nice to have (priority) labels Jul 21, 2021
@patak-dev patak-dev merged commit 828a8e5 into vitejs:main Jul 21, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@benmccann @aleclarson
chore: remove usage of querystring (vitejs#4342)
a8f7d23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace querystring with URLSearchParams
3 participants
@benmccann @patak-dev @Shinigami92