Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace querystring with URLSearchParams #4341

Closed
6 tasks done
benmccann opened this issue Jul 21, 2021 · 0 comments · Fixed by #4342
Closed
6 tasks done

Replace querystring with URLSearchParams #4341

benmccann opened this issue Jul 21, 2021 · 0 comments · Fixed by #4342
Labels
enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority)

Comments

@benmccann
Copy link
Collaborator

Describe the bug

The querystring API is considered legacy and it's recommended to use URLSearchParams instead. I'm getting a warning when building the SvelteKit codebase with Rollup and would like to get rid of the warning

Reproduction

import qs, { ParsedUrlQuery } from 'querystring'

System Info

Vite `master`

Used Package Manager

pnpm

Logs

default imported from external module 'querystring' but never used

Validations

@patak-dev patak-dev added enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority) and removed pending triage labels Jul 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants