DATA-3094: Add CLI args to SubmitCustomTrainingJobRequest #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpandiarajan20
added
ready-for-protos
tahiyasalam
reviewed
Sep 11, 2024
| @@ -69,6 +69,7 @@ message SubmitCustomTrainingJobRequest { | |||
| string organization_id = 3 [(tagger.v1.tags) = "bson:\"organization_id\" json:\"organization_id\""]; | |||
| string model_name = 4 [(tagger.v1.tags) = "bson:\"model_name\" json:\"model_name\""]; | |||
| string model_version = 5 [(tagger.v1.tags) = "bson:\"model_version\" json:\"model_version\""]; | |||
| map<string, string> arguments = 6; | |||
There was a problem hiding this comment.
Do we needs tags for this cc @sbal13 ?
There was a problem hiding this comment.
Sorry not sure what you mean. As in tags like we have for SubmitTrainingJobRequest?
repeated string tags = 6 [(tagger.v1.tags) = "bson:\"tags\" json:\"tags\""];
If so, then no, we don't have UI for selecting what tags to train on - custom scripts don't take tags IIRC, only the built-in script does. Do you think it would be useful to add?
There was a problem hiding this comment.
I meant the bson and json tags, though I'm not exactly sure what they're used for in this scenario.
There was a problem hiding this comment.
Yeah I'm not sure either! It looks like they're used to tell protobuf what attribute name to map to when marshalling (I have no idea if I'm using that word correctly, converting??) to BSON and JSON respectively, but in all cases the attribute name is the same in this file so not sure what it's doing.
tahiyasalam
approved these changes
Sep 13, 2024
vpandiarajan20
added
safe to test
maxhorowitz
added a commit
that referenced
this pull request
Sep 16, 2024
* main: (22 commits) DATA-3094: Add CLI args to SubmitCustomTrainingJobRequest (#550) bump min golang version (#548) DATA-3054: Added UpdateBoundingBox (#547) RSDK-8595 update docs with new behavior (#546) APP-3604 build endpoints for external oauth and repos (#544) add last updated to fragment proto (#540) APP-5851: Add optional visibility field to `CreateFragmentRequest` (#543) APP-5314 - add dates and limit to GetRobotPartLogsRequest (#538) RSDK-7903 Add unhealthy state and error field (#539) RSDK-8381 add viam server version to API (#537) [APP-5417]: Undo APP-5417 (#536) [APP-5417]: Accommodate pagination for GetRobotPartHistory in api (#535) Data 2816/get training job logs (#534) DATA-2792 - Add URL to UpdateRegistryItemRequest, but make it optional (#532) RSDK-8228 Add config status to machine status API (#531) Add revision field to config (#530) [APP-5420] Add ListMachineFragments request and response (#525) [APP-5400]: Add GetFragmentHistory proto (#524) RSDK-7899 Add MachineStatus to RobotService (#527) RSDK-8083: add LogPatternConfig field to RobotConfig API (#526) ...
maxhorowitz
added a commit
that referenced
this pull request
Sep 16, 2024
* main: (22 commits) DATA-3094: Add CLI args to SubmitCustomTrainingJobRequest (#550) bump min golang version (#548) DATA-3054: Added UpdateBoundingBox (#547) RSDK-8595 update docs with new behavior (#546) APP-3604 build endpoints for external oauth and repos (#544) add last updated to fragment proto (#540) APP-5851: Add optional visibility field to `CreateFragmentRequest` (#543) APP-5314 - add dates and limit to GetRobotPartLogsRequest (#538) RSDK-7903 Add unhealthy state and error field (#539) RSDK-8381 add viam server version to API (#537) [APP-5417]: Undo APP-5417 (#536) [APP-5417]: Accommodate pagination for GetRobotPartHistory in api (#535) Data 2816/get training job logs (#534) DATA-2792 - Add URL to UpdateRegistryItemRequest, but make it optional (#532) RSDK-8228 Add config status to machine status API (#531) Add revision field to config (#530) [APP-5420] Add ListMachineFragments request and response (#525) [APP-5400]: Add GetFragmentHistory proto (#524) RSDK-7899 Add MachineStatus to RobotService (#527) RSDK-8083: add LogPatternConfig field to RobotConfig API (#526) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
argumentfield to SubmitCustomTrainingJobRequest, map of string to string.